Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(169)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 2319143003: Roll back changes that broke the bots (TBR) (Closed)

Created:
4 years, 3 months ago by Brian Wilkerson
Modified:
4 years, 3 months ago
Reviewers:
scheglov
CC:
reviews_dartlang.org
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Roll back changes that broke the bots (TBR) Committed: https://github.com/dart-lang/sdk/commit/e5d10ceed6fd2fdd041a67869b4c958cbd6483eb

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -5 lines) Patch
M pkg/analyzer/tool/task_dependency_graph/generate.dart View 2 chunks +3 lines, -5 lines 0 comments Download

Messages

Total messages: 5 (2 generated)
Brian Wilkerson
It appears that the two code paths are not equivalent. I'm not sure why.
4 years, 3 months ago (2016-09-07 21:07:36 UTC) #2
Brian Wilkerson
Committed patchset #1 (id:1) manually as e5d10ceed6fd2fdd041a67869b4c958cbd6483eb (presubmit successful).
4 years, 3 months ago (2016-09-07 21:07:58 UTC) #4
scheglov
4 years, 3 months ago (2016-09-07 21:19:03 UTC) #5
Message was sent while issue was closed. 
lgtm

Powered by Google App Engine
This is Rietveld 408576698