Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(57)

Issue 2319133002: Add delay promise and change automation scripts (Closed)

Created:
4 years, 3 months ago by Navid Zolghadr
Modified:
4 years, 3 months ago
Reviewers:
dtapuska
CC:
chromium-reviews, blink-reviews, tfarina, blink-reviews-w3ctests_chromium.org, lanwei
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Add delay promise and change automation scripts Also update the scroll an element into the view as it may cause some internal div to scroll and fail the test. BUG=643215 Committed: https://crrev.com/d916caa601149ec4a2a09d588dae8bb6777b321b Cr-Commit-Position: refs/heads/master@{#417598}

Patch Set 1 #

Patch Set 2 : Remove a temporary comment #

Unified diffs Side-by-side diffs Delta from patch set Stats (+83 lines, -97 lines) Patch
M third_party/WebKit/LayoutTests/TestExpectations View 2 chunks +4 lines, -10 lines 0 comments Download
M third_party/WebKit/LayoutTests/imported/wpt_automation/pointerevents/pointerevent_common_input.js View 1 4 chunks +18 lines, -3 lines 0 comments Download
M third_party/WebKit/LayoutTests/imported/wpt_automation/pointerevents/pointerevent_touch-action-button-test_touch-manual-automation.js View 1 chunk +12 lines, -21 lines 0 comments Download
M third_party/WebKit/LayoutTests/imported/wpt_automation/pointerevents/pointerevent_touch-action-inherit_child-auto-child-none_touch-manual-automation.js View 1 chunk +2 lines, -2 lines 0 comments Download
M third_party/WebKit/LayoutTests/imported/wpt_automation/pointerevents/pointerevent_touch-action-inherit_child-none_touch-manual-automation.js View 1 chunk +2 lines, -2 lines 0 comments Download
M third_party/WebKit/LayoutTests/imported/wpt_automation/pointerevents/pointerevent_touch-action-inherit_child-pan-x-child-pan-x_touch-manual-automation.js View 1 chunk +2 lines, -2 lines 0 comments Download
M third_party/WebKit/LayoutTests/imported/wpt_automation/pointerevents/pointerevent_touch-action-inherit_child-pan-x-child-pan-y_touch-manual-automation.js View 1 chunk +2 lines, -2 lines 0 comments Download
M third_party/WebKit/LayoutTests/imported/wpt_automation/pointerevents/pointerevent_touch-action-inherit_highest-parent-none_touch-manual-automation.js View 1 chunk +2 lines, -2 lines 0 comments Download
M third_party/WebKit/LayoutTests/imported/wpt_automation/pointerevents/pointerevent_touch-action-inherit_parent-none_touch-manual-automation.js View 1 chunk +2 lines, -2 lines 0 comments Download
M third_party/WebKit/LayoutTests/imported/wpt_automation/pointerevents/pointerevent_touch-action-pan-x-pan-y-pan-y_touch-manual-automation.js View 1 chunk +2 lines, -2 lines 0 comments Download
M third_party/WebKit/LayoutTests/imported/wpt_automation/pointerevents/pointerevent_touch-action-span-test_touch-manual-automation.js View 1 chunk +12 lines, -19 lines 0 comments Download
M third_party/WebKit/LayoutTests/imported/wpt_automation/pointerevents/pointerevent_touch-action-svg-test_touch-manual-automation.js View 1 chunk +12 lines, -19 lines 0 comments Download
M third_party/WebKit/LayoutTests/imported/wpt_automation/pointerevents/pointerevent_touch-action-table-test_touch-manual-automation.js View 1 chunk +11 lines, -11 lines 0 comments Download

Messages

Total messages: 19 (9 generated)
Navid Zolghadr
4 years, 3 months ago (2016-09-07 16:09:41 UTC) #4
Navid Zolghadr
4 years, 3 months ago (2016-09-07 17:55:44 UTC) #9
Navid Zolghadr
On 2016/09/07 17:55:44, Navid Zolghadr wrote: dtapuska@ since you are adding automation scripts for new ...
4 years, 3 months ago (2016-09-08 15:20:31 UTC) #10
Navid Zolghadr
On 2016/09/07 17:55:44, Navid Zolghadr wrote: dtapuska@ since you are adding automation scripts for new ...
4 years, 3 months ago (2016-09-08 15:20:32 UTC) #11
Navid Zolghadr
On 2016/09/08 15:20:32, Navid Zolghadr wrote: > On 2016/09/07 17:55:44, Navid Zolghadr wrote: > > ...
4 years, 3 months ago (2016-09-09 14:28:15 UTC) #12
dtapuska
On 2016/09/09 14:28:15, Navid Zolghadr wrote: > On 2016/09/08 15:20:32, Navid Zolghadr wrote: > > ...
4 years, 3 months ago (2016-09-09 14:57:46 UTC) #13
Navid Zolghadr
On 2016/09/09 14:57:46, dtapuska wrote: > On 2016/09/09 14:28:15, Navid Zolghadr wrote: > > On ...
4 years, 3 months ago (2016-09-09 14:59:01 UTC) #14
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2319133002/20001
4 years, 3 months ago (2016-09-09 14:59:38 UTC) #16
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 3 months ago (2016-09-09 16:11:06 UTC) #17
commit-bot: I haz the power
4 years, 3 months ago (2016-09-09 16:14:32 UTC) #19
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/d916caa601149ec4a2a09d588dae8bb6777b321b
Cr-Commit-Position: refs/heads/master@{#417598}

Powered by Google App Engine
This is Rietveld 408576698