Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(54)

Issue 2319093004: Revert of [Fetch API] Start reading blob only when the reader wants to read contents. (Closed)

Created:
4 years, 3 months ago by lushnikov
Modified:
4 years, 3 months ago
Reviewers:
hiroshige, jkarlin, yhirano
CC:
chromium-reviews, blink-reviews, haraken
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of [Fetch API] Start reading blob only when the reader wants to read contents. (patchset #3 id:40001 of https://codereview.chromium.org/2303753003/ ) Reason for revert: Speculative revert: this patch is a suspect to cause Linux MSAN failures: https://uberchromegw.corp.google.com/i/chromium.webkit/builders/WebKit%20Linux%20MSAN/builds/12091 The other suspected patch, the only one related to canvas, was reverted and didn't help. Original issue's description: > [Fetch API] Start reading blob only when the reader wants to read contents. > > BUG=643174 > > Committed: https://crrev.com/f1ca96c413912ff1768e4274b8b7ac78eb41de64 > Cr-Commit-Position: refs/heads/master@{#416923} TBR=hiroshige@chromium.org,jkarlin@chromium.org,yhirano@chromium.org # Not skipping CQ checks because original CL landed more than 1 days ago. BUG=643174 Committed: https://crrev.com/2cbd2420c74783570442264a3e9a1c76cc42152e Cr-Commit-Position: refs/heads/master@{#417338}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+16 lines, -43 lines) Patch
M third_party/WebKit/Source/modules/fetch/FetchBlobDataConsumerHandle.cpp View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/modules/fetch/FetchBlobDataConsumerHandleTest.cpp View 8 chunks +14 lines, -42 lines 0 comments Download
M third_party/WebKit/Source/modules/fetch/FetchFormDataConsumerHandleTest.cpp View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 8 (3 generated)
lushnikov
Created Revert of [Fetch API] Start reading blob only when the reader wants to read ...
4 years, 3 months ago (2016-09-08 14:43:43 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2319093004/1
4 years, 3 months ago (2016-09-08 14:44:02 UTC) #3
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 3 months ago (2016-09-08 17:59:11 UTC) #5
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/2cbd2420c74783570442264a3e9a1c76cc42152e Cr-Commit-Position: refs/heads/master@{#417338}
4 years, 3 months ago (2016-09-08 18:02:01 UTC) #7
lushnikov
4 years, 3 months ago (2016-09-08 20:50:17 UTC) #8
Message was sent while issue was closed.
A revert of this CL (patchset #1 id:1) has been created in
https://codereview.chromium.org/2327583002/ by lushnikov@chromium.org.

The reason for reverting is: With the revert in place, the Linux MSAN is still
failing:

https://uberchromegw.corp.google.com/i/chromium.webkit/builders/WebKit%20Linu...

This proofs this patch to be innocent..

Powered by Google App Engine
This is Rietveld 408576698