Index: components/omnibox/browser/physical_web_provider.h |
diff --git a/components/omnibox/browser/physical_web_provider.h b/components/omnibox/browser/physical_web_provider.h |
index d4e7486c73a869a861560e8c996a9f6c023e42ca..d6b2dfdbe4e4dac0513c7e9ca15b9b420ae6f769 100644 |
--- a/components/omnibox/browser/physical_web_provider.h |
+++ b/components/omnibox/browser/physical_web_provider.h |
@@ -25,6 +25,18 @@ class PhysicalWebProvider : public AutocompleteProvider { |
void Start(const AutocompleteInput& input, bool minimal_changes) override; |
void Stop(bool clear_cached_results, bool due_to_user_inactivity) override; |
+ // The maximum number of match results to provide. If the number of nearby |
Mark P
2016/09/14 19:33:11
nit: Should got at the top of the class definition
mattreynolds
2016/09/14 19:42:24
Done.
|
+ // URLs exceeds this limit, an overflow item is created. Tapping the overflow |
+ // item navigates to a page with the full list of nearby URLs. The overflow |
+ // item is counted as a match result for the purposes of the match limit. |
+ // |
+ // ex: With kPhysicalWebMaxMatches == 1, there should be at most one |
+ // suggestion created by this provider. If there is a single nearby URL, then |
+ // the suggestion will be for that URL. If there are multiple nearby URLs, the |
+ // suggestion will be the overflow item which navigates to the WebUI when |
+ // tapped. |
+ static const size_t kPhysicalWebMaxMatches; |
+ |
private: |
PhysicalWebProvider(AutocompleteProviderClient* client, |
HistoryURLProvider* history_url_provider); |
@@ -38,9 +50,13 @@ class PhysicalWebProvider : public AutocompleteProvider { |
// Adds an overflow match item to |matches_| with a relevance score equal to |
// |relevance| and a label indicating there are |additional_url_count| more |
- // nearby URLs. Selecting the overflow item navigates to the Physical Web |
- // WebUI, which displays the full list of nearby URLs. |
- void AppendOverflowItem(int additional_url_count, int relevance); |
+ // nearby URLs. The page |title| of one of the additional nearby URLs will be |
+ // included in the label, truncating if necessary. Selecting the overflow item |
+ // navigates to the Physical Web WebUI, which displays the full list of nearby |
+ // URLs. |
+ void AppendOverflowItem(int additional_url_count, |
+ int relevance, |
+ const base::string16& title); |
AutocompleteProviderClient* client_; |