Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(101)

Issue 2319033002: Add WARN_UNUSED_RESULT to BytesConsumer read methods. (Closed)

Created:
4 years, 3 months ago by yhirano
Modified:
4 years, 3 months ago
Reviewers:
hiroshige
CC:
chromium-reviews, blink-reviews, haraken
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Add WARN_UNUSED_RESULT to BytesConsumer read methods. BUG=610195 Committed: https://crrev.com/748561e055b1f868345cdb8fa83b6d625f3e309d Cr-Commit-Position: refs/heads/master@{#418506}

Patch Set 1 #

Patch Set 2 : rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+27 lines, -9 lines) Patch
M third_party/WebKit/Source/modules/fetch/BytesConsumer.h View 3 chunks +4 lines, -3 lines 0 comments Download
M third_party/WebKit/Source/modules/fetch/BytesConsumerTestUtil.cpp View 1 1 chunk +4 lines, -1 line 0 comments Download
M third_party/WebKit/Source/modules/fetch/FetchDataLoader.cpp View 4 chunks +19 lines, -5 lines 0 comments Download

Messages

Total messages: 20 (13 generated)
yhirano
4 years, 3 months ago (2016-09-07 11:21:17 UTC) #4
hiroshige
lgtm.
4 years, 3 months ago (2016-09-07 12:58:24 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2319033002/1
4 years, 3 months ago (2016-09-13 15:58:15 UTC) #9
commit-bot: I haz the power
Try jobs failed on following builders: linux_android_rel_ng on master.tryserver.chromium.android (JOB_FAILED, https://build.chromium.org/p/tryserver.chromium.android/builders/linux_android_rel_ng/builds/140657) mac_chromium_compile_dbg_ng on master.tryserver.chromium.mac (JOB_FAILED, ...
4 years, 3 months ago (2016-09-13 16:01:04 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2319033002/20001
4 years, 3 months ago (2016-09-14 05:29:01 UTC) #17
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 3 months ago (2016-09-14 07:29:45 UTC) #18
commit-bot: I haz the power
4 years, 3 months ago (2016-09-14 07:32:00 UTC) #20
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/748561e055b1f868345cdb8fa83b6d625f3e309d
Cr-Commit-Position: refs/heads/master@{#418506}

Powered by Google App Engine
This is Rietveld 408576698