Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(459)

Unified Diff: content/renderer/render_view_impl.cc

Issue 231903002: Remove WebFrameClient stubs from RenderViewImpl. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Created 6 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « content/renderer/render_view_impl.h ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: content/renderer/render_view_impl.cc
diff --git a/content/renderer/render_view_impl.cc b/content/renderer/render_view_impl.cc
index e53ccc79efb68c93df45ffe53a0f68012ecfdd61..45942b1fcfe32edc4972ca6e69782aef75da3206 100644
--- a/content/renderer/render_view_impl.cc
+++ b/content/renderer/render_view_impl.cc
@@ -2117,14 +2117,6 @@ void RenderViewImpl::initializeLayerTreeView() {
// blink::WebFrameClient -----------------------------------------------------
-WebMediaPlayer* RenderViewImpl::createMediaPlayer(
- WebLocalFrame* frame,
- const blink::WebURL& url,
- WebMediaPlayerClient* client) {
- NOTREACHED();
- return NULL;
-}
-
blink::WebMediaPlayer* RenderViewImpl::CreateMediaPlayer(
RenderFrame* render_frame,
blink::WebLocalFrame* frame,
@@ -2528,19 +2520,6 @@ void RenderViewImpl::didUpdateCurrentHistoryItem(WebLocalFrame* frame) {
StartNavStateSyncTimerIfNecessary();
}
-void RenderViewImpl::willSendRequest(WebLocalFrame* frame,
- unsigned identifier,
- WebURLRequest& request,
- const WebURLResponse& redirect_response) {
- NOTREACHED();
-}
-
-void RenderViewImpl::didReceiveResponse(WebLocalFrame* frame,
- unsigned identifier,
- const WebURLResponse& response) {
- NOTREACHED();
-}
-
void RenderViewImpl::didFinishResourceLoad(WebLocalFrame* frame,
unsigned identifier) {
InternalDocumentStateData* internal_data =
@@ -2565,36 +2544,6 @@ void RenderViewImpl::didFinishResourceLoad(WebLocalFrame* frame,
}
}
-void RenderViewImpl::didLoadResourceFromMemoryCache(
- WebLocalFrame* frame,
- const WebURLRequest& request,
- const WebURLResponse& response) {
- NOTREACHED();
-}
-
-void RenderViewImpl::didDisplayInsecureContent(WebLocalFrame* frame) {
- NOTREACHED();
-}
-
-void RenderViewImpl::didRunInsecureContent(WebLocalFrame* frame,
- const WebSecurityOrigin& origin,
- const WebURL& target) {
- NOTREACHED();
-}
-
-void RenderViewImpl::didCreateScriptContext(WebLocalFrame* frame,
- v8::Handle<v8::Context> context,
- int extension_group,
- int world_id) {
- NOTREACHED();
-}
-
-void RenderViewImpl::willReleaseScriptContext(WebLocalFrame* frame,
- v8::Handle<v8::Context> context,
- int world_id) {
- NOTREACHED();
-}
-
void RenderViewImpl::CheckPreferredSize() {
// We don't always want to send the change messages over IPC, only if we've
// been put in that mode by getting a |ViewMsg_EnablePreferredSizeChangedMode|
@@ -2703,10 +2652,6 @@ void RenderViewImpl::didChangeScrollOffset(WebLocalFrame* frame) {
RenderViewObserver, observers_, DidChangeScrollOffset(frame));
}
-void RenderViewImpl::willInsertBody(blink::WebLocalFrame* frame) {
- NOTREACHED();
-}
-
void RenderViewImpl::didFirstVisuallyNonEmptyLayout(WebLocalFrame* frame) {
if (frame != webview()->mainFrame())
return;
@@ -2745,26 +2690,6 @@ void RenderViewImpl::SendFindReply(int request_id,
final_status_update));
}
-void RenderViewImpl::reportFindInPageMatchCount(int request_id,
- int count,
- bool final_update) {
- NOTREACHED();
-}
-
-void RenderViewImpl::reportFindInPageSelection(int request_id,
- int active_match_ordinal,
- const WebRect& selection_rect) {
- NOTREACHED();
-}
-
-void RenderViewImpl::requestStorageQuota(
- WebLocalFrame* frame,
- WebStorageQuotaType type,
- unsigned long long requested_size,
- blink::WebStorageQuotaCallbacks callbacks) {
- NOTREACHED();
-}
-
bool RenderViewImpl::willCheckAndDispatchMessageEvent(
blink::WebLocalFrame* sourceFrame,
blink::WebFrame* targetFrame,
@@ -2807,42 +2732,10 @@ bool RenderViewImpl::willCheckAndDispatchMessageEvent(
return true;
}
-void RenderViewImpl::willOpenSocketStream(
- WebSocketStreamHandle* handle) {
- NOTREACHED();
-}
-
-void RenderViewImpl::willStartUsingPeerConnectionHandler(
- blink::WebLocalFrame* frame,
- blink::WebRTCPeerConnectionHandler* handler) {
- NOTREACHED();
-}
-
blink::WebString RenderViewImpl::acceptLanguages() {
return WebString::fromUTF8(renderer_preferences_.accept_languages);
}
-blink::WebString RenderViewImpl::userAgentOverride(blink::WebLocalFrame* frame,
- const blink::WebURL& url) {
- NOTREACHED();
- return blink::WebString();
-}
-
-WebString RenderViewImpl::doNotTrackValue(WebLocalFrame* frame) {
- NOTREACHED();
- return blink::WebString();
-}
-
-bool RenderViewImpl::allowWebGL(WebLocalFrame* frame, bool default_value) {
- NOTREACHED();
- return false;
-}
-
-void RenderViewImpl::didLoseWebGLContext(blink::WebLocalFrame* frame,
- int arb_robustness_status_code) {
- NOTREACHED();
-}
-
// blink::WebPageSerializerClient implementation ------------------------------
void RenderViewImpl::didSerializeDataForFrame(
« no previous file with comments | « content/renderer/render_view_impl.h ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698