Issue 231903002: Remove WebFrameClient stubs from RenderViewImpl.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 231903002: Remove WebFrameClient stubs from RenderViewImpl. (Closed)

Created:
6 years, 8 months ago by Avi (use Gerrit)

Modified:
6 years, 8 months ago

Reviewers:
nasko

CC:
chromium-reviews, darin-cc_chromium.org, nasko+codewatch_chromium.org, jam, creis+watch_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

Remove WebFrameClient stubs from RenderViewImpl. BUG=361761 TEST=no change Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=262865

Created: 6 years, 8 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+0 lines, -155 lines)			Patch
	M	content/renderer/render_view_impl.h	View		2 chunks	+0 lines, -48 lines	0 comments	Download
	M	content/renderer/render_view_impl.cc	View		6 chunks	+0 lines, -107 lines	0 comments	Download

Total messages: 5 (0 generated)

Avi (use Gerrit)

So I'll remove them, as you suggested that I do.

6 years, 8 months ago (2014-04-09 21:05:30 UTC) #1

nasko

Awesome! Thanks for all the cleanup you've been doing! LGTM

6 years, 8 months ago (2014-04-09 21:07:28 UTC) #2

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/avi@chromium.org/231903002/1

6 years, 8 months ago (2014-04-09 21:09:41 UTC) #4

Message was sent while issue was closed.

Change committed as 262865