Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(880)

Issue 2319023002: Enable ANGLE workaround for For and While loops bug on Intel MacOSX (Closed)

Created:
4 years, 3 months ago by qiankun
Modified:
4 years, 3 months ago
CC:
chromium-reviews, piman+watch_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Enable ANGLE workaround for For and While loops bug on Intel MacOSX BUG=644669 TEST=deqp/functional/gles3/shaderloop_for/while.html CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel Committed: https://crrev.com/626d9576addcbc392fefbf02fdec0d822d782ae1 Cr-Commit-Position: refs/heads/master@{#419059}

Patch Set 1 #

Patch Set 2 : rebase #

Patch Set 3 : rebase only #

Total comments: 2

Patch Set 4 : update version #

Unified diffs Side-by-side diffs Delta from patch set Stats (+17 lines, -1 line) Patch
M gpu/command_buffer/service/gles2_cmd_decoder.cc View 1 2 1 chunk +2 lines, -0 lines 0 comments Download
M gpu/config/gpu_driver_bug_list_json.cc View 1 2 3 2 chunks +13 lines, -1 line 0 comments Download
M gpu/config/gpu_driver_bug_workaround_type.h View 1 2 1 chunk +2 lines, -0 lines 0 comments Download

Messages

Total messages: 16 (8 generated)
qiankun
PTAL. ANGLE side patch: https://chromium-review.googlesource.com/381678
4 years, 3 months ago (2016-09-15 12:13:19 UTC) #3
piman
https://codereview.chromium.org/2319023002/diff/40001/gpu/config/gpu_driver_bug_list_json.cc File gpu/config/gpu_driver_bug_list_json.cc (right): https://codereview.chromium.org/2319023002/diff/40001/gpu/config/gpu_driver_bug_list_json.cc#newcode22 gpu/config/gpu_driver_bug_list_json.cc:22: "version": "8.97", Please rev this.
4 years, 3 months ago (2016-09-15 18:04:12 UTC) #4
Jamie Madill
seems good. not an owner.
4 years, 3 months ago (2016-09-15 19:30:13 UTC) #5
qiankun
https://codereview.chromium.org/2319023002/diff/40001/gpu/config/gpu_driver_bug_list_json.cc File gpu/config/gpu_driver_bug_list_json.cc (right): https://codereview.chromium.org/2319023002/diff/40001/gpu/config/gpu_driver_bug_list_json.cc#newcode22 gpu/config/gpu_driver_bug_list_json.cc:22: "version": "8.97", On 2016/09/15 18:04:12, piman OOO back 2016-09-12 ...
4 years, 3 months ago (2016-09-15 22:21:39 UTC) #6
piman
lgtm
4 years, 3 months ago (2016-09-15 22:59:44 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2319023002/60001
4 years, 3 months ago (2016-09-16 00:34:34 UTC) #13
commit-bot: I haz the power
Committed patchset #4 (id:60001)
4 years, 3 months ago (2016-09-16 00:41:03 UTC) #14
commit-bot: I haz the power
4 years, 3 months ago (2016-09-16 00:42:59 UTC) #16
Message was sent while issue was closed.
Patchset 4 (id:??) landed as
https://crrev.com/626d9576addcbc392fefbf02fdec0d822d782ae1
Cr-Commit-Position: refs/heads/master@{#419059}

Powered by Google App Engine
This is Rietveld 408576698