runtime/vm/flow_graph_compiler.cc - Issue 23190035: Distinguish between malformed and malbounded types (fix issues 12552 and 12554).

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: runtime/vm/flow_graph_compiler.cc

Issue 23190035: Distinguish between malformed and malbounded types (fix issues 12552 and 12554). (Closed) Base URL: http://dart.googlecode.com/svn/branches/bleeding_edge/dart/

Patch Set: Created 7 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: runtime/vm/flow_graph_compiler.cc

===================================================================

--- runtime/vm/flow_graph_compiler.cc (revision 26566)

+++ runtime/vm/flow_graph_compiler.cc (working copy)

@@ -1098,7 +1098,7 @@

// Returns true if checking against this type is a direct class id comparison.

bool FlowGraphCompiler::TypeCheckAsClassEquality(const AbstractType& type) {

- ASSERT(type.IsFinalized() && !type.IsMalformed());

+ ASSERT(type.IsFinalized() && !type.IsMalformed() && !type.IsMalbounded(NULL));

// Requires CHA, which can be applied in optimized code only,

if (!FLAG_use_cha || !is_optimizing()) return false;

if (!type.IsInstantiated()) return false;

« no previous file with comments | « runtime/vm/flow_graph_builder.cc ('k') | runtime/vm/flow_graph_compiler_arm.cc » ('j') | runtime/vm/object.h » ('J')