Source/web/FrameLoaderClientImpl.cpp - Issue 23190034: Remove code related to title directionality, we never used it

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/web/FrameLoaderClientImpl.cpp

Issue 23190034: Remove code related to title directionality, we never used it (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: Created 7 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: Source/web/FrameLoaderClientImpl.cpp

diff --git a/Source/web/FrameLoaderClientImpl.cpp b/Source/web/FrameLoaderClientImpl.cpp

index fa853ec227c6b1003a421fa552937c384745b39d..e34b1507343e8297a64385c99a99716b06a5b5a2 100644

--- a/Source/web/FrameLoaderClientImpl.cpp

+++ b/Source/web/FrameLoaderClientImpl.cpp

@@ -371,10 +371,10 @@ void FrameLoaderClientImpl::dispatchDidStartProvisionalLoad()

m_webFrame->client()->didStartProvisionalLoad(m_webFrame);

}

-void FrameLoaderClientImpl::dispatchDidReceiveTitle(const StringWithDirection& title)

+void FrameLoaderClientImpl::dispatchDidReceiveTitle(const String& title)

{

if (m_webFrame->client())

- m_webFrame->client()->didReceiveTitle(m_webFrame, title.string(), title.direction() == LTR ? WebTextDirectionLeftToRight : WebTextDirectionRightToLeft);

+ m_webFrame->client()->didReceiveTitle(m_webFrame, title, WebTextDirectionLeftToRight);

}

void FrameLoaderClientImpl::dispatchDidChangeIcons(WebCore::IconType type)

« no previous file with comments | « Source/web/FrameLoaderClientImpl.h ('k') | no next file » | no next file with comments »