Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(943)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 23190020: Revert "The CL adds libpoppler to DEPS and adds a libpoppler-cpp gyp target for Linux, Windows, and… (Closed)

Created:
7 years, 4 months ago by vandebo (ex-Chrome)
Modified:
7 years, 4 months ago
Reviewers:
CC:
skia-review_googlegroups.com, ducky
Visibility:
Public.

Description

Revert "The CL adds libpoppler to DEPS and adds a libpoppler-cpp gyp target for Linux, Windows, and Mac. This does not currently change the GM tool to use poppler - that will be a refactor job in a separate CL." This reverts commit r10823 TBR=richardlin@chromium.org Committed: https://code.google.com/p/skia/source/detail?r=10828

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+56 lines, -14849 lines) Patch
D gyp/fontconfig.gyp View 1 chunk +0 lines, -101 lines 0 comments Download
M gyp/freetype.gyp View 2 chunks +56 lines, -29 lines 0 comments Download
D gyp/freetype.gypi View 1 chunk +0 lines, -65 lines 0 comments Download
M gyp/gm.gyp View 1 chunk +0 lines, -11 lines 0 comments Download
D gyp/iconv.gyp View 1 chunk +0 lines, -44 lines 0 comments Download
D gyp/poppler.gyp View 1 chunk +0 lines, -229 lines 0 comments Download
D src/utils/SkPDFRasterizer.h View 1 chunk +0 lines, -15 lines 0 comments Download
D src/utils/SkPDFRasterizer.cpp View 1 chunk +0 lines, -73 lines 0 comments Download
D third_party/fontconfig/LICENSE View 1 chunk +0 lines, -28 lines 0 comments Download
D third_party/fontconfig/LICENSE.win View 1 chunk +0 lines, -118 lines 0 comments Download
D third_party/fontconfig/README.chromium View 1 chunk +0 lines, -41 lines 0 comments Download
D third_party/fontconfig/config/fc-case/fccase.h View 1 chunk +0 lines, -330 lines 0 comments Download
D third_party/fontconfig/config/fc-glyphname/fcglyphname.h View 1 chunk +0 lines, -781 lines 0 comments Download
D third_party/fontconfig/config/fc-lang/fclang.h View 1 chunk +0 lines, -4173 lines 0 comments Download
D third_party/fontconfig/config/mac/config.h View 1 chunk +0 lines, -358 lines 0 comments Download
D third_party/fontconfig/config/mac/fcstdint.h View 1 chunk +0 lines, -9 lines 0 comments Download
D third_party/fontconfig/config/mac/src/fcalias.h View 1 chunk +0 lines, -388 lines 0 comments Download
D third_party/fontconfig/config/mac/src/fcaliastail.h View 1 chunk +0 lines, -438 lines 0 comments Download
D third_party/fontconfig/config/mac/src/fcftalias.h View 1 chunk +0 lines, -12 lines 0 comments Download
D third_party/fontconfig/config/mac/src/fcftaliastail.h View 1 chunk +0 lines, -20 lines 0 comments Download
D third_party/fontconfig/config/src/fcobjshash.h View 1 chunk +0 lines, -317 lines 0 comments Download
D third_party/fontconfig/config/windows/config.h View 1 chunk +0 lines, -237 lines 0 comments Download
D third_party/fontconfig/config/windows/dirent.h View 1 chunk +0 lines, -50 lines 0 comments Download
D third_party/fontconfig/config/windows/dirent.c View 1 chunk +0 lines, -145 lines 0 comments Download
D third_party/fontconfig/config/windows/fcstdint.h View 1 chunk +0 lines, -237 lines 0 comments Download
D third_party/fontconfig/config/windows/src/fcalias.h View 1 chunk +0 lines, -368 lines 0 comments Download
D third_party/fontconfig/config/windows/src/fcaliastail.h View 1 chunk +0 lines, -738 lines 0 comments Download
D third_party/fontconfig/config/windows/src/fcftalias.h View 1 chunk +0 lines, -12 lines 0 comments Download
D third_party/fontconfig/config/windows/src/fcftaliastail.h View 1 chunk +0 lines, -26 lines 0 comments Download
D third_party/fontconfig/config/windows/unistd.h View 1 chunk +0 lines, -4 lines 0 comments Download
D third_party/iconv/LICENSE View 1 chunk +0 lines, -482 lines 0 comments Download
D third_party/iconv/README.chromium View 1 chunk +0 lines, -77 lines 0 comments Download
D third_party/iconv/config/aliases.h View 1 chunk +0 lines, -1719 lines 0 comments Download
D third_party/iconv/config/canonical.h View 1 chunk +0 lines, -110 lines 0 comments Download
D third_party/iconv/config/canonical_dos.h View 1 chunk +0 lines, -15 lines 0 comments Download
D third_party/iconv/config/canonical_local.h View 1 chunk +0 lines, -2 lines 0 comments Download
D third_party/iconv/config/flags.h View 1 chunk +0 lines, -157 lines 0 comments Download
D third_party/iconv/config/windows/config.h View 1 chunk +0 lines, -926 lines 0 comments Download
D third_party/iconv/config/windows/iconv.h View 1 chunk +0 lines, -244 lines 0 comments Download
D third_party/iconv/config/windows/localcharset.h View 1 chunk +0 lines, -44 lines 0 comments Download
D third_party/poppler/LICENSE View 1 chunk +0 lines, -339 lines 0 comments Download
D third_party/poppler/README.chromium View 1 chunk +0 lines, -34 lines 0 comments Download
D third_party/poppler/config/linux/config.h View 1 chunk +0 lines, -259 lines 0 comments Download
D third_party/poppler/config/linux/poppler-config.h View 1 chunk +0 lines, -174 lines 0 comments Download
D third_party/poppler/config/mac/config.h View 1 chunk +0 lines, -259 lines 0 comments Download
D third_party/poppler/config/mac/poppler-config.h View 1 chunk +0 lines, -174 lines 0 comments Download
D third_party/poppler/config/poppler-version.h View 1 chunk +0 lines, -39 lines 0 comments Download
D third_party/poppler/config/windows/config.h View 1 chunk +0 lines, -225 lines 0 comments Download
D third_party/poppler/config/windows/poppler-config.h View 1 chunk +0 lines, -173 lines 0 comments Download

Messages

Total messages: 2 (0 generated)
vandebo (ex-Chrome)
7 years, 4 months ago (2013-08-20 17:03:54 UTC) #1
vandebo (ex-Chrome)
7 years, 4 months ago (2013-08-20 17:06:45 UTC) #2
Message was sent while issue was closed. 
Committed patchset #1 manually as r10828.

Powered by Google App Engine
This is Rietveld 408576698