Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(28)

Issue 23190013: Give bound function name for aesthetic matters (Closed)

Created:
7 years, 4 months ago by Peter.Rybin
Modified:
6 years, 8 months ago
Reviewers:
Yang
CC:
v8-dev, aandrey
Visibility:
Public.

Description

Give bound function name for aesthetic matters

Patch Set 1 #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+8 lines, -1 line) Patch
M src/v8natives.js View 1 chunk +1 line, -1 line 0 comments Download
M test/mjsunit/function-names.js View 1 chunk +7 lines, -0 lines 2 comments Download

Messages

Total messages: 3 (0 generated)
Peter.Rybin
Hi Yang, I'm not fully sure about this feature. Bound functions are frequently used. However ...
7 years, 4 months ago (2013-08-16 17:51:01 UTC) #1
Yang
On 2013/08/16 17:51:01, Peter.Rybin wrote: > Hi Yang, > > I'm not fully sure about ...
7 years, 4 months ago (2013-08-19 17:03:50 UTC) #2
Yang
7 years, 4 months ago (2013-08-19 17:04:05 UTC) #3
https://codereview.chromium.org/23190013/diff/1/test/mjsunit/function-names.js
File test/mjsunit/function-names.js (right):

https://codereview.chromium.org/23190013/diff/1/test/mjsunit/function-names.j...
test/mjsunit/function-names.js:138: print(boundFunction);
Those two print statements are unnecessary.

https://codereview.chromium.org/23190013/diff/1/test/mjsunit/function-names.j...
test/mjsunit/function-names.js:139:
assertTrue(boundFunction.name.indexOf("bound") != -1);
This fails, since the name is "BoundFunction" (upper case).

Powered by Google App Engine
This is Rietveld 408576698