Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(784)

Unified Diff: runtime/vm/class_finalizer.cc

Issue 23190003: ClassMirror.mixin (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart
Patch Set: Created 7 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: runtime/vm/class_finalizer.cc
diff --git a/runtime/vm/class_finalizer.cc b/runtime/vm/class_finalizer.cc
index 5b4a3703586d0ece2b0b75899632abaee9e62071..4b54f650b232c1513116c8fcddafe8af3b3a87db 100644
--- a/runtime/vm/class_finalizer.cc
+++ b/runtime/vm/class_finalizer.cc
@@ -1234,7 +1234,11 @@ void ClassFinalizer::ResolveAndFinalizeMemberTypes(const Class& cls) {
// interfaces to refer to the respective type parameters of the mixin
// application class.
void ClassFinalizer::CloneTypeParameters(const Class& mixapp_class) {
- ASSERT(mixapp_class.NumTypeParameters() == 0);
+ if (mixapp_class.NumTypeParameters() != 0) {
rmacnak 2013/08/15 22:29:06 This isn't right.
+ // Mixin applications created by typedef can introduce their own type
+ // paramaters.
regis 2013/08/15 22:51:48 parameters
+ return;
regis 2013/08/15 22:51:48 Mmm, nothing to clone? I have to think about this.
+ }
const AbstractType& super_type =
AbstractType::Handle(mixapp_class.super_type());

Powered by Google App Engine
This is Rietveld 408576698