Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(371)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 2318973003: Test cl (Closed)

Created:
4 years, 3 months ago by Bugs Nash
Modified:
4 years, 3 months ago
Reviewers:
CC:
chromium-reviews, sof, eae+blinkwatch, blink-reviews-dom_chromium.org, dglazkov+blink, blink-reviews, rwlbuis
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Test cl Added checks for LayoutObjects before calling clearComputedStyle. Made clearComputedStyle redirect to setComputedStyle. BUG=

Patch Set 1 #

Patch Set 2 : Removed LayoutObject check from detachLayoutTree." #

Patch Set 3 : Replaced LayoutObject check for detachLayoutTree and removed check from attachLayoutTree #

Patch Set 4 : Replaced LayoutObject check for attachLayoutTree and removed check from recalcStyle #

Unified diffs Side-by-side diffs Delta from patch set Stats (+18 lines, -5 lines) Patch
M third_party/WebKit/Source/core/dom/Element.cpp View 1 2 3 2 chunks +3 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/core/dom/ElementRareData.h View 1 chunk +15 lines, -3 lines 0 comments Download

Messages

Total messages: 16 (16 generated)
Bugs Nash
The CQ bit was checked by bugsnash@chromium.org to run a CQ dry run
4 years, 3 months ago (2016-09-08 05:40:57 UTC) #1
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2318973003/1
4 years, 3 months ago (2016-09-08 05:41:30 UTC) #2
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
4 years, 3 months ago (2016-09-08 08:16:03 UTC) #3
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
4 years, 3 months ago (2016-09-08 08:16:04 UTC) #4
Bugs Nash
The CQ bit was checked by bugsnash@chromium.org to run a CQ dry run
4 years, 3 months ago (2016-09-08 22:58:42 UTC) #5
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2318973003/20001
4 years, 3 months ago (2016-09-08 22:59:23 UTC) #6
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
4 years, 3 months ago (2016-09-09 00:06:29 UTC) #7
commit-bot: I haz the power
Dry run: Try jobs failed on following builders: cast_shell_linux on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/cast_shell_linux/builds/221605)
4 years, 3 months ago (2016-09-09 00:06:30 UTC) #8
Bugs Nash
The CQ bit was checked by bugsnash@chromium.org to run a CQ dry run
4 years, 3 months ago (2016-09-09 00:39:06 UTC) #9
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2318973003/40001
4 years, 3 months ago (2016-09-09 00:39:48 UTC) #10
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
4 years, 3 months ago (2016-09-09 00:49:42 UTC) #11
commit-bot: I haz the power
Dry run: Try jobs failed on following builders: cast_shell_android on master.tryserver.chromium.android (JOB_FAILED, https://build.chromium.org/p/tryserver.chromium.android/builders/cast_shell_android/builds/125905) chromeos_amd64-generic_chromium_compile_only_ng on ...
4 years, 3 months ago (2016-09-09 00:49:43 UTC) #12
Bugs Nash
The CQ bit was checked by bugsnash@chromium.org to run a CQ dry run
4 years, 3 months ago (2016-09-09 01:28:29 UTC) #13
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2318973003/60001
4 years, 3 months ago (2016-09-09 01:28:51 UTC) #14
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
4 years, 3 months ago (2016-09-09 02:54:18 UTC) #15
commit-bot: I haz the power
4 years, 3 months ago (2016-09-09 02:54:19 UTC) #16 
Dry run: Try jobs failed on following builders:
  android_n5x_swarming_rel on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/android_n5x_...)

Powered by Google App Engine
This is Rietveld 408576698