Revert of Delete the class WebRtcVideoCapturerAdapter::MediaVideoFrameFactory

Revert of Delete the class WebRtcVideoCapturerAdapter::MediaVideoFrameFactory (patchset #2 id:100001 of https://codereview.chromium.org/2270723002/ )

Reason for revert:
This CL breaks CPU adaptation. It should scale to the adapted resolution, but this CL crops instead. The result looks like zoomed in video when CPU adaptation kicks in.

Original issue's description:
> Reland of Delete the class WebRtcVideoCapturerAdapter::MediaVideoFrameFactory (patchset #1 id:1 of https://codereview.chromium.org/2263183002/ )
> 
> Reason for revert:
> Identified and fixed timestamp problem.
> 
> Original issue's description:
> > Revert of Delete the class WebRtcVideoCapturerAdapter::MediaVideoFrameFactory (patchset #5 id:80001 of https://codereview.chromium.org/2244213002/ )
> >
> > Reason for revert:
> > Somehow breaks timestamping. Reverting for investigation. To reproduce, run
> >
> > ./browser_tests --gtest_filter='WebRtcVideoQualityBrowserTests/WebRtcVideoQualityBrowserTest*' --run-manual --ui-test-action-max-timeout=200000
> >
> > This produces lots of warnings like
> >
> > [1:14:0822/153830:WARNING:video_capture_input.cc(79)] Same/old NTP timestamp (3680861906110 <= 3680861906110) for incoming frame. Dropping.
> > [1:14:0822/153830:WARNING:video_capture_input.cc(79)] Same/old NTP timestamp (3680861906042 <= 3680861906042) for incoming frame. Dropping.
> >
> > Original issue's description:
> > > Delete the class WebRtcVideoCapturerAdapter::MediaVideoFrameFactory
> > >
> > > Instead, use the AdaptFrame and OnFrame methods of the VideoCapturer
> > > base class.
> > >
> > > This cl also applies the new timestamp aligner logic, to translate
> > > Chrome's camera timestamps into the timescale of rtc::TimeMicros(). No
> > > other change in behavior is intended.
> > >
> > > BUG=webrtc:5682, webrtc:5740, 516700
> > >
> > > Committed: https://crrev.com/5b9a4b339447b033ca52244a02c0bef17067385f
> > > Cr-Commit-Position: refs/heads/master@{#413093}
> >
> > TBR=perkj@chromium.org
> > # Not skipping CQ checks because original CL landed more than 1 days ago.
> > BUG=webrtc:5682, webrtc:5740, 516700
> >
> > Committed: https://crrev.com/e977fbdcd25a49046e23976dfe2f0a667c4ad037
> > Cr-Commit-Position: refs/heads/master@{#413444}
> 
> BUG=webrtc:5682, webrtc:5740, 516700
> 
> Committed: https://crrev.com/918a16ff0f94202936bde994cf7885a0780894ae
> Cr-Commit-Position: refs/heads/master@{#414986}

TBR=perkj@chromium.org,kjellander@chromium.org,nisse@chromium.org
# Not skipping CQ checks because original CL landed more than 1 days ago.
BUG=webrtc:5682, webrtc:5740, chromium:516700, chromium:635592

[magjed_chromium, 2016-09-08 15:27:53]

Created Revert of Delete the class
WebRtcVideoCapturerAdapter::MediaVideoFrameFactory

[magjed_chromium, 2016-09-08 15:28:20]

Description was changed from

==========
Revert of Delete the class WebRtcVideoCapturerAdapter::MediaVideoFrameFactory
(patchset #2 id:100001 of https://codereview.chromium.org/2270723002/ )

Reason for revert:
This CL breaks CPU adaptation. It should scale to the adapted resolution, but
this CL crops instead. The result looks like zoomed in video when CPU adaptation
kicks in.

Original issue's description:
> Reland of Delete the class WebRtcVideoCapturerAdapter::MediaVideoFrameFactory
(patchset #1 id:1 of https://codereview.chromium.org/2263183002/ )
> 
> Reason for revert:
> Identified and fixed timestamp problem.
> 
> Original issue's description:
> > Revert of Delete the class
WebRtcVideoCapturerAdapter::MediaVideoFrameFactory (patchset #5 id:80001 of
https://codereview.chromium.org/2244213002/ )
> >
> > Reason for revert:
> > Somehow breaks timestamping. Reverting for investigation. To reproduce, run
> >
> > ./browser_tests
--gtest_filter='WebRtcVideoQualityBrowserTests/WebRtcVideoQualityBrowserTest*'
--run-manual --ui-test-action-max-timeout=200000
> >
> > This produces lots of warnings like
> >
> > [1:14:0822/153830:WARNING:video_capture_input.cc(79)] Same/old NTP timestamp
(3680861906110 <= 3680861906110) for incoming frame. Dropping.
> > [1:14:0822/153830:WARNING:video_capture_input.cc(79)] Same/old NTP timestamp
(3680861906042 <= 3680861906042) for incoming frame. Dropping.
> >
> > Original issue's description:
> > > Delete the class WebRtcVideoCapturerAdapter::MediaVideoFrameFactory
> > >
> > > Instead, use the AdaptFrame and OnFrame methods of the VideoCapturer
> > > base class.
> > >
> > > This cl also applies the new timestamp aligner logic, to translate
> > > Chrome's camera timestamps into the timescale of rtc::TimeMicros(). No
> > > other change in behavior is intended.
> > >
> > > BUG=webrtc:5682, webrtc:5740, 516700
> > >
> > > Committed: https://crrev.com/5b9a4b339447b033ca52244a02c0bef17067385f
> > > Cr-Commit-Position: refs/heads/master@{#413093}
> >
> > TBR=perkj@chromium.org
> > # Not skipping CQ checks because original CL landed more than 1 days ago.
> > BUG=webrtc:5682, webrtc:5740, 516700
> >
> > Committed: https://crrev.com/e977fbdcd25a49046e23976dfe2f0a667c4ad037
> > Cr-Commit-Position: refs/heads/master@{#413444}
> 
> BUG=webrtc:5682, webrtc:5740, 516700
> 
> Committed: https://crrev.com/918a16ff0f94202936bde994cf7885a0780894ae
> Cr-Commit-Position: refs/heads/master@{#414986}

TBR=perkj@chromium.org,kjellander@chromium.org,nisse@chromium.org
# Not skipping CQ checks because original CL landed more than 1 days ago.
BUG=webrtc:5682, webrtc:5740, 516700
==========

to

==========
Revert of Delete the class WebRtcVideoCapturerAdapter::MediaVideoFrameFactory
(patchset #2 id:100001 of https://codereview.chromium.org/2270723002/ )

Reason for revert:
This CL breaks CPU adaptation. It should scale to the adapted resolution, but
this CL crops instead. The result looks like zoomed in video when CPU adaptation
kicks in.

Original issue's description:
> Reland of Delete the class WebRtcVideoCapturerAdapter::MediaVideoFrameFactory
(patchset #1 id:1 of https://codereview.chromium.org/2263183002/ )
> 
> Reason for revert:
> Identified and fixed timestamp problem.
> 
> Original issue's description:
> > Revert of Delete the class
WebRtcVideoCapturerAdapter::MediaVideoFrameFactory (patchset #5 id:80001 of
https://codereview.chromium.org/2244213002/ )
> >
> > Reason for revert:
> > Somehow breaks timestamping. Reverting for investigation. To reproduce, run
> >
> > ./browser_tests
--gtest_filter='WebRtcVideoQualityBrowserTests/WebRtcVideoQualityBrowserTest*'
--run-manual --ui-test-action-max-timeout=200000
> >
> > This produces lots of warnings like
> >
> > [1:14:0822/153830:WARNING:video_capture_input.cc(79)] Same/old NTP timestamp
(3680861906110 <= 3680861906110) for incoming frame. Dropping.
> > [1:14:0822/153830:WARNING:video_capture_input.cc(79)] Same/old NTP timestamp
(3680861906042 <= 3680861906042) for incoming frame. Dropping.
> >
> > Original issue's description:
> > > Delete the class WebRtcVideoCapturerAdapter::MediaVideoFrameFactory
> > >
> > > Instead, use the AdaptFrame and OnFrame methods of the VideoCapturer
> > > base class.
> > >
> > > This cl also applies the new timestamp aligner logic, to translate
> > > Chrome's camera timestamps into the timescale of rtc::TimeMicros(). No
> > > other change in behavior is intended.
> > >
> > > BUG=webrtc:5682, webrtc:5740, 516700
> > >
> > > Committed: https://crrev.com/5b9a4b339447b033ca52244a02c0bef17067385f
> > > Cr-Commit-Position: refs/heads/master@{#413093}
> >
> > TBR=perkj@chromium.org
> > # Not skipping CQ checks because original CL landed more than 1 days ago.
> > BUG=webrtc:5682, webrtc:5740, 516700
> >
> > Committed: https://crrev.com/e977fbdcd25a49046e23976dfe2f0a667c4ad037
> > Cr-Commit-Position: refs/heads/master@{#413444}
> 
> BUG=webrtc:5682, webrtc:5740, 516700
> 
> Committed: https://crrev.com/918a16ff0f94202936bde994cf7885a0780894ae
> Cr-Commit-Position: refs/heads/master@{#414986}

TBR=perkj@chromium.org,kjellander@chromium.org,nisse@chromium.org
# Not skipping CQ checks because original CL landed more than 1 days ago.
BUG=webrtc:5682, webrtc:5740, chromium:516700, chromium:635592
==========

[magjed_chromium, 2016-09-08 15:28:39]

The CQ bit was checked by magjed@chromium.org

[commit-bot: I haz the power, 2016-09-08 15:28:51]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-09-08 16:09:42]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-09-08 16:09:43]

Try jobs failed on following builders:
  cast_shell_linux on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/cast_shell_linu...)

[nisse-chromium (ooo August 14), 2016-09-09 12:40:10]

On 2016/09/08 16:09:43, commit-bot: I haz the power wrote:
> Try jobs failed on following builders:
>   cast_shell_linux on master.tryserver.chromium.linux (JOB_FAILED,
>
http://build.chromium.org/p/tryserver.chromium.linux/builders/cast_shell_linu...)

Close this now? Fixed in https://codereview.chromium.org/2323573004