Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(87)

Issue 2318953003: Comment about why we don't record evals from inner scopes in the script scope (Closed)

Created:
4 years, 3 months ago by jochen (gone - plz use gerrit)
Modified:
4 years, 3 months ago
Reviewers:
marja
CC:
v8-reviews_googlegroups.com
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Comment about why we don't record evals from inner scopes in the script scope R=marja@chromium.org BUG= Committed: https://crrev.com/1ccb832da7ff19028b46190d328f2460ba6bc456 Cr-Commit-Position: refs/heads/master@{#39236}

Patch Set 1 #

Total comments: 1

Patch Set 2 : updates #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -1 line) Patch
M src/ast/scopes.h View 1 1 chunk +4 lines, -1 line 0 comments Download

Messages

Total messages: 12 (5 generated)
jochen (gone - plz use gerrit)
4 years, 3 months ago (2016-09-07 08:53:29 UTC) #1
jochen (gone - plz use gerrit)
ptal
4 years, 3 months ago (2016-09-07 09:06:22 UTC) #4
marja
lgtm
4 years, 3 months ago (2016-09-07 09:09:42 UTC) #5
marja
oops forgot to publish https://codereview.chromium.org/2318953003/diff/1/src/ast/scopes.h File src/ast/scopes.h (right): https://codereview.chromium.org/2318953003/diff/1/src/ast/scopes.h#newcode204 src/ast/scopes.h:204: // calls then, the outer ...
4 years, 3 months ago (2016-09-07 09:10:13 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2318953003/20001
4 years, 3 months ago (2016-09-07 09:11:37 UTC) #9
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 3 months ago (2016-09-07 09:42:10 UTC) #10
commit-bot: I haz the power
4 years, 3 months ago (2016-09-07 09:42:49 UTC) #12
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/1ccb832da7ff19028b46190d328f2460ba6bc456
Cr-Commit-Position: refs/heads/master@{#39236}

Powered by Google App Engine
This is Rietveld 408576698