Replace Setup API with PnP Configuration Manager in MidiManagerWinrt

Replace Setup API with PnP Configuration Manager in MidiManagerWinrt

Now retrieving driver information with PnP Configuration Manager, which is much
faster than using Setup API.
With the new approach we are now able to fetch information from the actual
device driver, instead of the software interface on top which seems to be always
provided by Microsoft.

BUG=512433, 642604
R=toyoshim@chromium.org

Committed: https://crrev.com/e6dffa1061e486bde2448c01e314e244497def46
Cr-Commit-Position: refs/heads/master@{#417536}

[Shao-Chuan Lee, 2016-09-07 08:26:52]

PTAL

https://codereview.chromium.org/2318953002/diff/1/media/midi/BUILD.gn
File media/midi/BUILD.gn (right):

https://codereview.chromium.org/2318953002/diff/1/media/midi/BUILD.gn#newcode140
media/midi/BUILD.gn:140: libs += [ "cfgmgr32.lib" ]
This library is available since Windows 2000, and is currently used in base.
TODO: should add /DELAYLOAD:cfgmgr32.dll ldflag as in base/BUILD.gn

[Shao-Chuan Lee, 2016-09-07 09:01:05]

https://codereview.chromium.org/2318953002/diff/1/media/midi/BUILD.gn
File media/midi/BUILD.gn (right):

https://codereview.chromium.org/2318953002/diff/1/media/midi/BUILD.gn#newcode140
media/midi/BUILD.gn:140: libs += [ "cfgmgr32.lib" ]
On 2016/09/07 08:26:52, Shao-Chuan Lee wrote:
> This library is available since Windows 2000, and is currently used in base.
> TODO: should add /DELAYLOAD:cfgmgr32.dll ldflag as in base/BUILD.gn

Not very familiar with GN, but it looks like media/midi/BUILD.gn depends on
base/BUILD.gn and the DELAYLOAD flag is already specified in
all_dependent_configs (through base_win_linker_flag).

[Takashi Toyoshima, 2016-09-07 09:10:03]

The CQ bit was checked by toyoshim@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-09-07 09:10:23]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Takashi Toyoshima, 2016-09-07 09:22:34]

https://codereview.chromium.org/2318953002/diff/1/media/midi/midi_manager_win...
File media/midi/midi_manager_winrt.cc (right):

https://codereview.chromium.org/2318953002/diff/1/media/midi/midi_manager_win...
media/midi/midi_manager_winrt.cc:269: // This is the maximum string length in
driver INF files.
If you know an official document about this magic number, can you have a link
here as a comment?

https://codereview.chromium.org/2318953002/diff/1/media/midi/midi_manager_win...
media/midi/midi_manager_winrt.cc:297: VLOG(1) << "CM_Locate_DevNode failed:
CONFIGRET 0x" << std::hex << cr;
Hum.... another kind of error code again :/
CM_MapCrToWin32Err() would help to use existing PrintHr infra?

[Takashi Toyoshima, 2016-09-07 10:17:02]

https://codereview.chromium.org/2318953002/diff/1/media/midi/BUILD.gn
File media/midi/BUILD.gn (right):

https://codereview.chromium.org/2318953002/diff/1/media/midi/BUILD.gn#newcode140
media/midi/BUILD.gn:140: libs += [ "cfgmgr32.lib" ]
Probably, we do not need this? Or need only on is_component_build?

[commit-bot: I haz the power, 2016-09-07 10:57:50]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-09-07 10:57:51]

Dry run: This issue passed the CQ dry run.

[Shao-Chuan Lee, 2016-09-08 06:23:30]

https://codereview.chromium.org/2318953002/diff/1/media/midi/midi_manager_win...
File media/midi/midi_manager_winrt.cc (right):

https://codereview.chromium.org/2318953002/diff/1/media/midi/midi_manager_win...
media/midi/midi_manager_winrt.cc:269: // This is the maximum string length in
driver INF files.
On 2016/09/07 09:22:34, toyoshim wrote:
> If you know an official document about this magic number, can you have a link
> here as a comment?

Now retrieving buffer size from CM_Get_DevNode_Property() and dynamically
allocate buffer.

https://codereview.chromium.org/2318953002/diff/1/media/midi/midi_manager_win...
media/midi/midi_manager_winrt.cc:297: VLOG(1) << "CM_Locate_DevNode failed:
CONFIGRET 0x" << std::hex << cr;
On 2016/09/07 09:22:34, toyoshim wrote:
> Hum.... another kind of error code again :/
> CM_MapCrToWin32Err() would help to use existing PrintHr infra?

Tried this and found only a few error codes are mapped to WinAPI errors, should
be better to print the original code for debug purposes.

[Shao-Chuan Lee, 2016-09-08 06:29:45]

https://codereview.chromium.org/2318953002/diff/1/media/midi/BUILD.gn
File media/midi/BUILD.gn (right):

https://codereview.chromium.org/2318953002/diff/1/media/midi/BUILD.gn#newcode140
media/midi/BUILD.gn:140: libs += [ "cfgmgr32.lib" ]
On 2016/09/07 10:17:02, toyoshim wrote:
> Probably, we do not need this? Or need only on is_component_build?

This is required in component build, and adding this doesn't break static build.
If we add this only in component build, we are assuming base always require this
library. Maybe a potential problem in the future?

[Takashi Toyoshima, 2016-09-09 05:17:42]

https://codereview.chromium.org/2318953002/diff/1/media/midi/midi_manager_win...
File media/midi/midi_manager_winrt.cc (right):

https://codereview.chromium.org/2318953002/diff/1/media/midi/midi_manager_win...
media/midi/midi_manager_winrt.cc:297: VLOG(1) << "CM_Locate_DevNode failed:
CONFIGRET 0x" << std::hex << cr;
So could you left what you tried and why you do like this as comments?

https://codereview.chromium.org/2318953002/diff/20001/media/midi/BUILD.gn
File media/midi/BUILD.gn (right):

https://codereview.chromium.org/2318953002/diff/20001/media/midi/BUILD.gn#new...
media/midi/BUILD.gn:140: libs += [ "cfgmgr32.lib" ]
Could you try without this line?

[Shao-Chuan Lee, 2016-09-09 05:44:47]

https://codereview.chromium.org/2318953002/diff/1/media/midi/midi_manager_win...
File media/midi/midi_manager_winrt.cc (right):

https://codereview.chromium.org/2318953002/diff/1/media/midi/midi_manager_win...
media/midi/midi_manager_winrt.cc:297: VLOG(1) << "CM_Locate_DevNode failed:
CONFIGRET 0x" << std::hex << cr;
On 2016/09/09 05:17:41, toyoshim wrote:
> So could you left what you tried and why you do like this as comments?

Done.

https://codereview.chromium.org/2318953002/diff/20001/media/midi/BUILD.gn
File media/midi/BUILD.gn (right):

https://codereview.chromium.org/2318953002/diff/20001/media/midi/BUILD.gn#new...
media/midi/BUILD.gn:140: libs += [ "cfgmgr32.lib" ]
On 2016/09/09 05:17:42, toyoshim wrote:
> Could you try without this line?

Now including only if is_component_build.

[Takashi Toyoshima, 2016-09-09 06:26:46]

lgtm

[Shao-Chuan Lee, 2016-09-09 06:27:10]

The CQ bit was checked by shaochuan@chromium.org

[commit-bot: I haz the power, 2016-09-09 06:27:26]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-09-09 08:24:31]

Committed patchset #3 (id:40001)

[commit-bot: I haz the power, 2016-09-09 08:26:55]

Description was changed from

==========
Replace Setup API with PnP Configuration Manager in MidiManagerWinrt

Now retrieving driver information with PnP Configuration Manager, which is much
faster than using Setup API.
With the new approach we are now able to fetch information from the actual
device driver, instead of the software interface on top which seems to be always
provided by Microsoft.

BUG=512433,642604
R=toyoshim@chromium.org
==========

to

==========
Replace Setup API with PnP Configuration Manager in MidiManagerWinrt

Now retrieving driver information with PnP Configuration Manager, which is much
faster than using Setup API.
With the new approach we are now able to fetch information from the actual
device driver, instead of the software interface on top which seems to be always
provided by Microsoft.

BUG=512433,642604
R=toyoshim@chromium.org

Committed: https://crrev.com/e6dffa1061e486bde2448c01e314e244497def46
Cr-Commit-Position: refs/heads/master@{#417536}
==========

[commit-bot: I haz the power, 2016-09-09 08:26:56]

Patchset 3 (id:??) landed as
https://crrev.com/e6dffa1061e486bde2448c01e314e244497def46
Cr-Commit-Position: refs/heads/master@{#417536}