Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(114)

Issue 2318943002: Revert of Remove --ignition-staging to --ignition-osr implication. (Closed)

Created:
4 years, 3 months ago by Michael Starzinger
Modified:
4 years, 3 months ago
Reviewers:
Benedikt Meurer, Jarin
CC:
v8-reviews_googlegroups.com, Michael Hablich, Michael Starzinger
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Revert of Remove --ignition-staging to --ignition-osr implication. (patchset #1 id:1 of https://codereview.chromium.org/2298613003/ ) Reason for revert: Re-enable to get new data after recent changes. Original issue's description: > Remove --ignition-staging to --ignition-osr implication. > > Ignition OSR to turbofan seems to cause instruction selector crashes > (where instructions selector gets simplified operators, probably > because we break the effect chain somehow). > > BUG=chromium:641893 > > Committed: https://crrev.com/26df3e230ebd8c7d1cd95ea54155959eee7cb830 > Cr-Commit-Position: refs/heads/master@{#39045} TBR=bmeurer@chromium.org,jarin@chromium.org # Not skipping CQ checks because original CL landed more than 1 days ago. BUG=chromium:641893 Committed: https://crrev.com/8a1747d08c763107c6bd45f960a1684cab4a9ca9 Cr-Commit-Position: refs/heads/master@{#39231}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -0 lines) Patch
M src/flag-definitions.h View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 6 (2 generated)
Michael Starzinger
Created Revert of Remove --ignition-staging to --ignition-osr implication.
4 years, 3 months ago (2016-09-07 07:33:49 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2318943002/1
4 years, 3 months ago (2016-09-07 07:33:56 UTC) #3
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 3 months ago (2016-09-07 08:02:31 UTC) #4
commit-bot: I haz the power
4 years, 3 months ago (2016-09-07 08:03:02 UTC) #6
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/8a1747d08c763107c6bd45f960a1684cab4a9ca9
Cr-Commit-Position: refs/heads/master@{#39231}

Powered by Google App Engine
This is Rietveld 408576698