Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1099)

Unified Diff: media/filters/decrypting_demuxer_stream.cc

Issue 2318933008: media: Update logging to display the missing keyId (Closed)
Patch Set: Created 4 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | media/filters/decrypting_video_decoder.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: media/filters/decrypting_demuxer_stream.cc
diff --git a/media/filters/decrypting_demuxer_stream.cc b/media/filters/decrypting_demuxer_stream.cc
index 0e31ef4a8f15335a7b925d1da4ba575e17d2677f..4d3d66fc8d64e62e3f8c4c0ba20dd0a76ebf132d 100644
--- a/media/filters/decrypting_demuxer_stream.cc
+++ b/media/filters/decrypting_demuxer_stream.cc
@@ -9,6 +9,7 @@
#include "base/location.h"
#include "base/logging.h"
#include "base/single_thread_task_runner.h"
+#include "base/strings/string_number_conversions.h"
#include "media/base/bind_to_current_loop.h"
#include "media/base/decoder_buffer.h"
#include "media/base/media_log.h"
@@ -296,8 +297,12 @@ void DecryptingDemuxerStream::DeliverBuffer(
}
if (status == Decryptor::kNoKey) {
- DVLOG(2) << "DoDeliverBuffer() - kNoKey";
- MEDIA_LOG(DEBUG, media_log_) << GetDisplayName() << ": no key";
+ std::string key_id = pending_buffer_to_decrypt_->decrypt_config()->key_id();
+ std::string missing_key_id = base::HexEncode(key_id.data(), key_id.size());
+ DVLOG(1) << "DeliverBuffer() - kNoKey, missing keyID " << missing_key_id;
xhwang 2016/09/09 18:20:00 here and below, "missing keyID" is a bit ambiguous
jrummell 2016/09/12 19:53:30 Done.
+ MEDIA_LOG(INFO, media_log_) << GetDisplayName()
+ << ": no key, missing keyId " << missing_key_id;
+
if (need_to_try_again_if_nokey) {
// The |state_| is still kPendingDecrypt.
DecryptPendingBuffer();
« no previous file with comments | « no previous file | media/filters/decrypting_video_decoder.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698