media: Update logging to display the missing keyId

media: Update logging to display the missing keyId

When playing encrypted media and playing stalls due to being unable
to decrypt the data, include the keyId missing in the logging output
(that includes chrome://media-internals).

BUG=645304
TEST=checked chrome://media-internals

Committed: https://crrev.com/21b0da050a97c275677ce0d15c143086fc3c0107
Cr-Commit-Position: refs/heads/master@{#418079}

[jrummell, 2016-09-09 02:24:16]

jrummell@chromium.org changed reviewers:
+ xhwang@chromium.org

[jrummell, 2016-09-09 02:24:17]

PTAL

[xhwang, 2016-09-09 18:20:00]

LGTM with two nits

https://chromiumcodereview.appspot.com/2318933008/diff/1/media/filters/decryp...
File media/filters/decrypting_demuxer_stream.cc (right):

https://chromiumcodereview.appspot.com/2318933008/diff/1/media/filters/decryp...
media/filters/decrypting_demuxer_stream.cc:1: // Copyright (c) 2012 The Chromium
Authors. All rights reserved.
Can you also update DecryptingAudioDecoder?

https://chromiumcodereview.appspot.com/2318933008/diff/1/media/filters/decryp...
media/filters/decrypting_demuxer_stream.cc:302: DVLOG(1) << "DeliverBuffer() -
kNoKey, missing keyID " << missing_key_id;
here and below, "missing keyID" is a bit ambiguous. We really are "missing the
key for key ID xx". How about:

"... no key for key ID " << missing_key_id;

[jrummell, 2016-09-12 19:53:31]

Thanks for the review.

https://codereview.chromium.org/2318933008/diff/1/media/filters/decrypting_de...
File media/filters/decrypting_demuxer_stream.cc (right):

https://codereview.chromium.org/2318933008/diff/1/media/filters/decrypting_de...
media/filters/decrypting_demuxer_stream.cc:1: // Copyright (c) 2012 The Chromium
Authors. All rights reserved.
On 2016/09/09 18:20:00, xhwang (slow) wrote:
> Can you also update DecryptingAudioDecoder?

Done.

https://codereview.chromium.org/2318933008/diff/1/media/filters/decrypting_de...
media/filters/decrypting_demuxer_stream.cc:302: DVLOG(1) << "DeliverBuffer() -
kNoKey, missing keyID " << missing_key_id;
On 2016/09/09 18:20:00, xhwang (slow) wrote:
> here and below, "missing keyID" is a bit ambiguous. We really are "missing the
> key for key ID xx". How about:
> 
> "... no key for key ID " << missing_key_id;

Done.

[jrummell, 2016-09-12 19:53:35]

The CQ bit was checked by jrummell@chromium.org

[jrummell, 2016-09-12 19:53:36]

The patchset sent to the CQ was uploaded after l-g-t-m from xhwang@chromium.org
Link to the patchset: https://codereview.chromium.org/2318933008/#ps20001
(title: "add DAD")

[commit-bot: I haz the power, 2016-09-12 19:53:53]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[xhwang, 2016-09-12 21:17:20]

(for future changes) It'll be nice if we also have logs when the decoder tries
to resume playback, so that from the logs we know we are not stuck in the no_key
state. Today, we only see no_key and not decoding events, and it's hard to tell
whether we already get a new key and tried to resume.

[commit-bot: I haz the power, 2016-09-12 22:28:18]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2016-09-12 22:31:23]

Description was changed from

==========
media: Update logging to display the missing keyId

When playing encrypted media and playing stalls due to being unable
to decrypt the data, include the keyId missing in the logging output
(that includes chrome://media-internals).

BUG=645304
TEST=checked chrome://media-internals
==========

to

==========
media: Update logging to display the missing keyId

When playing encrypted media and playing stalls due to being unable
to decrypt the data, include the keyId missing in the logging output
(that includes chrome://media-internals).

BUG=645304
TEST=checked chrome://media-internals

Committed: https://crrev.com/21b0da050a97c275677ce0d15c143086fc3c0107
Cr-Commit-Position: refs/heads/master@{#418079}
==========

[commit-bot: I haz the power, 2016-09-12 22:31:25]

Patchset 2 (id:??) landed as
https://crrev.com/21b0da050a97c275677ce0d15c143086fc3c0107
Cr-Commit-Position: refs/heads/master@{#418079}