Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1269)

Issue 2318933007: Fix layout test for redeclaration of arguments. (Closed)

Created:
4 years, 3 months ago by lpy
Modified:
4 years, 3 months ago
Reviewers:
ojan
CC:
blink-reviews, chromium-reviews
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Fix layout test for redeclaration of arguments. This patch re-enables js/mozilla/strict/13.1.html and fixes lexical redeclaration of arguments. BUG=v8:4577 Committed: https://crrev.com/78395bceb9c7dcfd38170e1d2a17de2042de6719 Cr-Commit-Position: refs/heads/master@{#417395}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+12 lines, -17 lines) Patch
M third_party/WebKit/LayoutTests/TestExpectations View 1 chunk +0 lines, -2 lines 0 comments Download
M third_party/WebKit/LayoutTests/fast/js/mozilla/strict/13.1-expected.txt View 3 chunks +6 lines, -6 lines 0 comments Download
M third_party/WebKit/LayoutTests/fast/js/mozilla/strict/script-tests/13.1.js View 3 chunks +6 lines, -9 lines 0 comments Download

Messages

Total messages: 12 (7 generated)
lpy
PTAL.
4 years, 3 months ago (2016-09-08 20:12:42 UTC) #6
ojan
lgtm
4 years, 3 months ago (2016-09-08 20:56:26 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2318933007/1
4 years, 3 months ago (2016-09-08 20:57:18 UTC) #9
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 3 months ago (2016-09-08 21:03:46 UTC) #10
commit-bot: I haz the power
4 years, 3 months ago (2016-09-08 21:05:54 UTC) #12
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/78395bceb9c7dcfd38170e1d2a17de2042de6719
Cr-Commit-Position: refs/heads/master@{#417395}

Powered by Google App Engine
This is Rietveld 408576698