Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(303)

Issue 2318933006: [SPV2] Add the device scale factor to the root transform node (Closed)

Created:
4 years, 3 months ago by pdr.
Modified:
4 years, 3 months ago
Reviewers:
ajuma, chrishtr, trchen
CC:
ajuma+watch_chromium.org, blink-reviews, blink-reviews-platform-graphics_chromium.org, Rik, chromium-reviews, danakj+watch_chromium.org, dshwang, drott+blinkwatch_chromium.org, krit, f(malita), jbroman, Justin Novosad, pdr+graphicswatchlist_chromium.org, rwlbuis, Stephen Chennney
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[SPV2] Add the device scale factor to the root transform node This patch sets the device scale factor on cc's root transform node, fixing several layout tests. This approach is different from how cc builds property trees (see post_local_scale_factor in property_tree_builder's AddTransformNodeIfNeeded) where a post_local transform is used, but aligns closer to blink's approach of using a single transform per transform node. This approach is temporary and will need to be refactored when we begin supporting viewport transforms such as pinch-zoom. BUG=642240 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2 Committed: https://crrev.com/73249085cf0d583b3267d500e3a48aaf514596c7 Cr-Commit-Position: refs/heads/master@{#417394}

Patch Set 1 #

Patch Set 2 : Refactor into helper on PropertyTreeManager #

Unified diffs Side-by-side diffs Delta from patch set Stats (+12 lines, -12 lines) Patch
M third_party/WebKit/LayoutTests/FlagExpectations/enable-slimming-paint-v2 View 1 chunk +0 lines, -12 lines 0 comments Download
M third_party/WebKit/Source/platform/graphics/compositing/PaintArtifactCompositor.cpp View 1 4 chunks +12 lines, -0 lines 0 comments Download

Messages

Total messages: 13 (8 generated)
pdr.
4 years, 3 months ago (2016-09-08 17:23:44 UTC) #7
ajuma
lgtm
4 years, 3 months ago (2016-09-08 17:30:14 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2318933006/20001
4 years, 3 months ago (2016-09-08 20:51:16 UTC) #10
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 3 months ago (2016-09-08 20:56:52 UTC) #11
commit-bot: I haz the power
4 years, 3 months ago (2016-09-08 21:00:07 UTC) #13
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/73249085cf0d583b3267d500e3a48aaf514596c7
Cr-Commit-Position: refs/heads/master@{#417394}

Powered by Google App Engine
This is Rietveld 408576698