Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(633)

Unified Diff: third_party/WebKit/Source/bindings/scripts/generate_init_partial_interfaces.py

Issue 2318933002: [Bindings] Remove aggregation of generated binding code (Closed)
Patch Set: Fix import order Created 4 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/bindings/scripts/generate_init_partial_interfaces.py
diff --git a/third_party/WebKit/Source/bindings/scripts/generate_init_partial_interfaces.py b/third_party/WebKit/Source/bindings/scripts/generate_init_partial_interfaces.py
index a604e57f8731786dc0c2c2f80521f8fea0cc5622..d3a49dffa231f0891cc2972ab2e4de723088fd0b 100755
--- a/third_party/WebKit/Source/bindings/scripts/generate_init_partial_interfaces.py
+++ b/third_party/WebKit/Source/bindings/scripts/generate_init_partial_interfaces.py
@@ -10,10 +10,11 @@ from optparse import OptionParser
import os
import posixpath
import sys
-from utilities import write_file
-
-from aggregate_generated_bindings import extract_meta_data
+from utilities import get_file_contents
+from utilities import idl_filename_to_interface_name
from utilities import read_idl_files_list_from_file
+from utilities import should_generate_impl_file_from_idl
+from utilities import write_file
_COPYRIGHT = """// Copyright 2014 The Chromium Authors. All rights reserved.
@@ -55,6 +56,33 @@ def parse_options():
return options
+def extract_meta_data(file_paths):
+ """Extracts interface name from each IDL file."""
+ meta_data_list = []
+
+ for file_path in file_paths:
+ if not file_path.endswith('.idl'):
+ print 'WARNING: non-IDL file passed: "%s"' % file_path
+ continue
+ if not os.path.exists(file_path):
+ print 'WARNING: file not found: "%s"' % file_path
+ continue
+
+ idl_file_contents = get_file_contents(file_path)
+ if not should_generate_impl_file_from_idl(idl_file_contents):
+ continue
+
+ # Extract interface name from file name
+ interface_name = idl_filename_to_interface_name(file_path)
+
+ meta_data = {
+ 'name': interface_name,
+ }
+ meta_data_list.append(meta_data)
+
+ return meta_data_list
+
+
def main():
options = parse_options()

Powered by Google App Engine
This is Rietveld 408576698