Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(10)

Side by Side Diff: third_party/WebKit/Source/bindings/modules/v8/BUILD.gn

Issue 2318933002: [Bindings] Remove aggregation of generated binding code (Closed)
Patch Set: Fix import order Created 4 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 # Copyright 2014 The Chromium Authors. All rights reserved. 1 # Copyright 2014 The Chromium Authors. All rights reserved.
2 # Use of this source code is governed by a BSD-style license that can be 2 # Use of this source code is governed by a BSD-style license that can be
3 # found in the LICENSE file. 3 # found in the LICENSE file.
4 4
5 import("//third_party/WebKit/Source/bindings/modules/v8/generated.gni") 5 import("//third_party/WebKit/Source/bindings/modules/v8/generated.gni")
6 import("//third_party/WebKit/Source/bindings/scripts/scripts.gni") 6 import("//third_party/WebKit/Source/bindings/scripts/scripts.gni")
7 import("//third_party/WebKit/Source/modules/modules.gni") 7 import("//third_party/WebKit/Source/modules/modules.gni")
8 import("//third_party/WebKit/Source/modules/modules_idl_files.gni") 8 import("//third_party/WebKit/Source/modules/modules_idl_files.gni")
9 9
10 visibility = [ "//third_party/WebKit/*" ] 10 visibility = [ "//third_party/WebKit/*" ]
11 11
12 # bindings_modules_generated in modules/v8/generated.gyp 12 # bindings_modules_generated in modules/v8/generated.gyp
13 group("bindings_modules_generated") { 13 group("bindings_modules_generated") {
14 public_deps = [ 14 public_deps = [
15 ":bindings_modules_impl_generated", 15 ":bindings_modules_impl_generated",
16 ":bindings_modules_v8_generated_aggregate",
17 ":bindings_modules_v8_generated_individual",
18 ":bindings_modules_v8_generated_init_partial", 16 ":bindings_modules_v8_generated_init_partial",
19 ":bindings_modules_v8_generated_partial_aggregate", 17 ":generate_bindings_modules_v8_interfaces",
20 ":bindings_modules_v8_generated_partial_individual", 18 ":generate_bindings_modules_v8_partial_interfaces",
21 ] 19 ]
22 } 20 }
23 21
24 # bindings_modules_generated_aggregate in modules/v8/generated.gyp 22 idl_compiler("generate_bindings_modules_v8_interfaces") {
25 aggregate_generated_bindings("bindings_modules_v8_generated_aggregate") {
26 sources = modules_definition_idl_files
27 component_dir = "modules"
28 is_partial = false
29 outputs = bindings_modules_generated_aggregate_files
30 }
31
32 # bindings_modules_generated_individual in modules/v8/generated.gyp
33 idl_compiler("bindings_modules_v8_generated_individual") {
34 # Note in GYP this is modules_interface_idl_files but this variable is just 23 # Note in GYP this is modules_interface_idl_files but this variable is just
35 # defined to modules_definition_idl_files. 24 # defined to modules_definition_idl_files.
36 sources = modules_definition_idl_files 25 sources = modules_definition_idl_files
37 output_dir = bindings_modules_v8_output_dir 26 output_dir = bindings_modules_v8_output_dir
38 output_name_suffix = "" 27 output_name_suffix = ""
39 target_component = "modules" 28 target_component = "modules"
40 } 29 }
41 30
42 # bindings_modules_impl_generated in modules/v8/generated.gyp
43 idl_impl("bindings_modules_impl_generated") { 31 idl_impl("bindings_modules_impl_generated") {
44 sources = modules_dictionary_idl_files 32 sources = modules_dictionary_idl_files
45 outputs = bindings_modules_generated_union_type_files + 33 outputs = bindings_modules_generated_union_type_files +
46 generated_modules_dictionary_files 34 generated_modules_dictionary_files
47 output_dir = bindings_modules_v8_output_dir 35 output_dir = bindings_modules_v8_output_dir
48 target_component = "modules" 36 target_component = "modules"
49 } 37 }
50 38
51 # bindings_modules_generated_individual in modules/v8/generated.gyp 39 idl_compiler("generate_bindings_modules_v8_partial_interfaces") {
52 idl_compiler("bindings_modules_v8_generated_partial_individual") {
53 # Note in GYP this is modules_interface_idl_files but this variable is just 40 # Note in GYP this is modules_interface_idl_files but this variable is just
54 # defined to modules_definition_idl_files. 41 # defined to modules_definition_idl_files.
55 sources = core_idl_with_modules_dependency_files + 42 sources = core_idl_with_modules_dependency_files +
56 webcore_testing_idl_with_modules_dependency_files 43 webcore_testing_idl_with_modules_dependency_files
57 output_dir = bindings_modules_v8_output_dir 44 output_dir = bindings_modules_v8_output_dir
58 output_name_suffix = "Partial" 45 output_name_suffix = "Partial"
59 target_component = "modules" 46 target_component = "modules"
60 } 47 }
61 48
62 # bindings_modules_generated_aggregate in modules/v8/generated.gyp
63 aggregate_generated_bindings(
64 "bindings_modules_v8_generated_partial_aggregate") {
65 sources = core_idl_with_modules_dependency_files
66 component_dir = "modules"
67 is_partial = true
68 outputs = bindings_modules_generated_partial_aggregate_files
69 }
70
71 # GYP version: Source/bindings/modules/v8/generated.gyp:bindings_modules_v8_gene rated_init_partial 49 # GYP version: Source/bindings/modules/v8/generated.gyp:bindings_modules_v8_gene rated_init_partial
72 action("bindings_modules_v8_generated_init_partial") { 50 action("bindings_modules_v8_generated_init_partial") {
73 script = "$bindings_scripts_dir/generate_init_partial_interfaces.py" 51 script = "$bindings_scripts_dir/generate_init_partial_interfaces.py"
74 52
75 inputs = [ 53 inputs = [
76 "$bindings_modules_output_dir/InterfacesInfoOverall.pickle", 54 "$bindings_modules_output_dir/InterfacesInfoOverall.pickle",
77 ] 55 ]
78 outputs = [ 56 outputs = [
79 bindings_modules_generated_init_partial_interfaces_file, 57 bindings_modules_generated_init_partial_interfaces_file,
80 ] 58 ]
81 59
82 # Put the IDL file list in a response file to avoid command-line limits. 60 # Put the IDL file list in a response file to avoid command-line limits.
83 response_file_contents = 61 response_file_contents =
84 rebase_path(core_idl_with_modules_dependency_files, root_build_dir) 62 rebase_path(core_idl_with_modules_dependency_files, root_build_dir)
85 63
86 args = [ 64 args = [
87 "--idl-files-list", 65 "--idl-files-list",
88 "{{response_file_name}}", 66 "{{response_file_name}}",
89 "--output", 67 "--output",
90 rebase_path(bindings_modules_generated_init_partial_interfaces_file, 68 rebase_path(bindings_modules_generated_init_partial_interfaces_file,
91 root_build_dir), 69 root_build_dir),
92 "--write-file-only-if-changed=1", 70 "--write-file-only-if-changed=1",
93 ] 71 ]
94 72
95 deps = [ 73 deps = [
96 "//third_party/WebKit/Source/bindings/modules:interfaces_info", 74 "//third_party/WebKit/Source/bindings/modules:interfaces_info",
97 ] 75 ]
98 } 76 }
OLDNEW
« no previous file with comments | « third_party/WebKit/Source/bindings/core/v8/BUILD.gn ('k') | third_party/WebKit/Source/bindings/modules/v8/generated.gni » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698