Prompt to delete pending edits before changing the Gerrit CL description.

Prompt to delete pending edits before changing the Gerrit CL description.

BUG=641838
Committed: https://chromium.googlesource.com/chromium/tools/depot_tools/+/e2d6fd987e17c0a099382419f76fdffffea7659a

[dsansome, 2016-09-07 04:25:20]

dsansome@chromium.org changed reviewers:
+ tandrii@chromium.org

[tandrii(chromium), 2016-09-07 13:33:39]

This is just great. LGTM % lightweight nit

https://codereview.chromium.org/2318903002/diff/1/git_cl.py
File git_cl.py (right):

https://codereview.chromium.org/2318903002/diff/1/git_cl.py#newcode1396
git_cl.py:1396: def UpdateDescription(self, force, description):
light suggestion: i'd add force=False as second argument.

https://codereview.chromium.org/2318903002/diff/1/git_cl.py#newcode2302
git_cl.py:2302: 'unpublished\nedit.  Either publish the edit in the Gerrit web
UI '
nit: i prefer not avoid manual text wrapping (ie no '\n' on this line)

[dsansome, 2016-09-08 07:07:17]

https://codereview.chromium.org/2318903002/diff/1/git_cl.py
File git_cl.py (right):

https://codereview.chromium.org/2318903002/diff/1/git_cl.py#newcode1396
git_cl.py:1396: def UpdateDescription(self, force, description):
On 2016/09/07 13:33:39, tandrii(chromium) wrote:
> light suggestion: i'd add force=False as second argument.

Done.

https://codereview.chromium.org/2318903002/diff/1/git_cl.py#newcode2302
git_cl.py:2302: 'unpublished\nedit.  Either publish the edit in the Gerrit web
UI '
On 2016/09/07 13:33:39, tandrii(chromium) wrote:
> nit: i prefer not avoid manual text wrapping (ie no '\n' on this line)

Done.

[dsansome, 2016-09-08 07:07:25]

The CQ bit was checked by dsansome@chromium.org

[dsansome, 2016-09-08 07:07:26]

The patchset sent to the CQ was uploaded after l-g-t-m from tandrii@chromium.org
Link to the patchset: https://codereview.chromium.org/2318903002/#ps20001
(title: "CL comments")

[commit-bot: I haz the power, 2016-09-08 07:07:33]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-09-08 07:10:50]

Description was changed from

==========
Prompt to delete pending edits before changing the Gerrit CL description.

BUG=641838
==========

to

==========
Prompt to delete pending edits before changing the Gerrit CL description.

BUG=641838

Committed:
https://chromium.googlesource.com/chromium/tools/depot_tools/+/e2d6fd987e17c0...
==========

[commit-bot: I haz the power, 2016-09-08 07:10:50]

Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/tools/depot_tools/+/e2d6fd987e17c0...