Issue 23189022: [Android] Adds directory cleanup/creation for code coverage

Issue 23189022: [Android] Adds directory cleanup/creation for code coverage (Closed)

Created:
7 years, 4 months ago by gkanwar1

Modified:
7 years, 3 months ago

Reviewers:
craigdh, Isaac (away), frankf

CC:
chromium-reviews, craigdh+watch_chromium.org, bulach+watch_chromium.org, yfriedman+watch_chromium.org, ilevy-cc_chromium.org, klundberg+watch_chromium.org, frankf+watch_chromium.org

Base URL:
https://chromium.googlesource.com/chromium/src.git@master

Visibility:
Public.

More Reviews

Description

[Android] Adds directory cleanup/creation for code coverage NOTRY=True BUG= R=craigdh@chromium.org, ilevy@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=219592

Patch Set 2 : Adds a soft create for the coverage dir #

Patch Set 4 : Moves dir creation to a non-threaded location #

Total comments: 2

Patch Set 5 : #

Created: 7 years, 3 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+9 lines, -1 line)			Patch
	M	build/android/buildbot/bb_device_steps.py	View	1 2 3 4	2 chunks	+4 lines, -1 line	0 comments	Download
	M	build/android/pylib/instrumentation/setup.py	View	1 2 3 4	2 chunks	+5 lines, -0 lines	0 comments	Download

Messages

Total messages: 7 (0 generated)

Expand Messages | Collapse Messages

gkanwar1

This should just clear the coverage directory on all coverage test runs.

7 years, 4 months ago (2013-08-24 02:14:07 UTC) #1

frankf

https://codereview.chromium.org/23189022/diff/1/build/android/buildbot/bb_device_steps.py File build/android/buildbot/bb_device_steps.py (right): https://codereview.chromium.org/23189022/diff/1/build/android/buildbot/bb_device_steps.py#newcode311 build/android/buildbot/bb_device_steps.py:311: os.mkdir(options.coverage_dir) It makes more sense to do this in ...

7 years, 4 months ago (2013-08-24 02:17:19 UTC) #2

Isaac (away)

buildbot lgtm w/ nit. https://codereview.chromium.org/23189022/diff/13001/build/android/buildbot/bb_device_steps.py File build/android/buildbot/bb_device_steps.py (right): https://codereview.chromium.org/23189022/diff/13001/build/android/buildbot/bb_device_steps.py#newcode376 build/android/buildbot/bb_device_steps.py:376: shutil.rmtree(options.coverage_dir, ignore_errors=True) This is a ...

7 years, 4 months ago (2013-08-25 00:25:41 UTC) #4

frankf

https://codereview.chromium.org/23189022/diff/13001/build/android/buildbot/bb_device_steps.py File build/android/buildbot/bb_device_steps.py (right): https://codereview.chromium.org/23189022/diff/13001/build/android/buildbot/bb_device_steps.py#newcode376 build/android/buildbot/bb_device_steps.py:376: shutil.rmtree(options.coverage_dir, ignore_errors=True) On 2013/08/25 00:25:41, Isaac wrote: > This ...

7 years, 3 months ago (2013-08-26 17:49:00 UTC) #5

frankf

7 years, 3 months ago (2013-08-26 19:54:33 UTC) #7

Message was sent while issue was closed.

Committed patchset #5 manually as r219592 (presubmit successful).

Expand Messages | Collapse Messages