sync/internal_api/public/base/cancelation_observer.h - Issue 23189021: sync: Gracefully handle very early shutdown

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: sync/internal_api/public/base/cancelation_observer.h

Issue 23189021: sync: Gracefully handle very early shutdown (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Fixes for first set of review comments Created 7 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

OLD	NEW
(Empty)
	1 // Copyright (c) 2013 The Chromium Authors. All rights reserved.

	2 // Use of this source code is governed by a BSD-style license that can be

	3 // found in the LICENSE file.

	4

	5 #ifndef SYNC_INTERNAL_API_PUBLIC_BASE_CANCELATION_OBSERVER_H_

	6 #define SYNC_INTERNAL_API_PUBLIC_BASE_CANCELATION_OBSERVER_H_

	7

	8 #include "sync/base/sync_export.h"

	9

	10 namespace syncer {

	11

	12 // Interface for classes that handle signals from the CancelationSignal.

	13 class SYNC_EXPORT_PRIVATE CancelationObserver {

	14 public:

	15 CancelationObserver();

	16 virtual ~CancelationObserver() = 0;

	17 virtual void OnStopRequested() = 0;
	tim (not reviewing) 2013/09/06 21:47:34 Add a comment that this is invoked while holding a Add a comment that this is invoked while holding a lock, and that the Observer should try to return as quickly as possible. rlarocque 2013/09/06 22:42:53 Done. Show quoted text On 2013/09/06 21:47:34, timsteele wrote: > Add a comment that this is invoked while holding a lock, and that the Observer > should try to return as quickly as possible. Done.
	18 };

	19

	20 } // namespace syncer

	21

	22 #endif // SYNC_INTERNAL_API_PUBLIC_BASE_CANCELATION_OBSERVER_H_

OLD	NEW