tools/dom/scripts/htmlrenamer.py - Issue 23189014: Removing more dom_ methods.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: tools/dom/scripts/htmlrenamer.py

Issue 23189014: Removing more dom_ methods. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Patch Set: Created 7 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: tools/dom/scripts/htmlrenamer.py

diff --git a/tools/dom/scripts/htmlrenamer.py b/tools/dom/scripts/htmlrenamer.py

index 6834f8e0f250e69ae53696510d4f1da2662950c9..ea368b3b0da79ffad83212843f12e092bed967bf 100644

--- a/tools/dom/scripts/htmlrenamer.py

+++ b/tools/dom/scripts/htmlrenamer.py

@@ -159,14 +159,8 @@ convert_to_future_members = monitored.Set(

dom_private_html_members = monitored.Set('htmlrenamer.private_html_members', [

'Document.createElement',

'Document.createElementNS',

- 'Document.createRange',

- 'Element.getAttribute',

- 'Element.getAttributeNS',

- 'Element.setAttribute',

- 'Element.setAttributeNS',

'EventTarget.addEventListener',

'EventTarget.removeEventListener',

- 'Node.childNodes',

])

# Members from the standard dom that should not be exposed publicly in dart:html

@@ -218,9 +212,13 @@ private_html_members = monitored.Set('htmlrenamer.private_html_members', [

'Element.children',

'Element.childElementCount',

'Element.firstElementChild',

+ 'Element.getAttribute',

+ 'Element.getAttributeNS',

'Element.getElementsByTagName',

'Element.scrollIntoView',

'Element.scrollIntoViewIfNeeded',

+ 'Element.setAttribute',

+ 'Element.setAttributeNS',

'Element.removeAttribute',

'Element.removeAttributeNS',

'Element.hasAttribute',

@@ -279,6 +277,7 @@ private_html_members = monitored.Set('htmlrenamer.private_html_members', [

'MutationEvent.initMutationEvent',

'MutationObserver.observe',

'Node.attributes',

+ 'Node.childNodes',

'Node.localName',

'Node.namespaceURI',

'Node.removeChild',

« no previous file with comments | « tests/html/safe_dom_test.dart ('k') | tools/dom/src/AttributeMap.dart » ('j') | no next file with comments »