Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(618)

Unified Diff: samples/third_party/dromaeo/tests/dom-attr-html.dart

Issue 23189014: Removing more dom_ methods. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart
Patch Set: Created 7 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: samples/third_party/dromaeo/tests/dom-attr-html.dart
diff --git a/samples/third_party/dromaeo/tests/dom-attr-html.dart b/samples/third_party/dromaeo/tests/dom-attr-html.dart
index dd1c075aad0d6b4926692002c59caec1b05de719..6a67840b81ebfd06c373d6077621e970ee5f1747 100644
--- a/samples/third_party/dromaeo/tests/dom-attr-html.dart
+++ b/samples/third_party/dromaeo/tests/dom-attr-html.dart
@@ -18,7 +18,7 @@ void main() {
new Suite(window, 'dom-attr')
.test('getAttribute', () {
for (int i = 0; i < num; i++)
- ret = elem.$dom_getAttribute('id');
blois 2013/08/27 16:08:10 This introduces a significant perf cost and will i
+ ret = elem.attributes['id'];
})
.test('element.property', () {
for (int i = 0; i < num * 2; i++)
@@ -26,7 +26,7 @@ void main() {
})
.test('setAttribute', () {
for (int i = 0; i < num; i++)
- a.$dom_setAttribute('id', 'foo');
+ a.attributes['id'] = 'foo';
})
.test('element.property = value', () {
for (int i = 0; i < num; i++)

Powered by Google App Engine
This is Rietveld 408576698