Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(235)

Unified Diff: sdk/lib/html/dart2js/html_dart2js.dart

Side-by-side diff isn't available for this file because of its large size.
Issue 23189014: Removing more dom_ methods. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart
Patch Set: Created 7 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
Download patch
Index: sdk/lib/html/dart2js/html_dart2js.dart
diff --git a/sdk/lib/html/dart2js/html_dart2js.dart b/sdk/lib/html/dart2js/html_dart2js.dart
index e80ddea1e8862362fefb7921d071ffcd24caa181..2a3422b74e7828ee44f8f70e53caad6dd087ae5d 100644
--- a/sdk/lib/html/dart2js/html_dart2js.dart
+++ b/sdk/lib/html/dart2js/html_dart2js.dart
@@ -7140,7 +7140,7 @@ class Document extends Node native "Document"
@JSName('createRange')
@DomName('Document.createRange')
@DocsEditable()
- Range $dom_createRange() native;
+ Range _createRange() native;
@JSName('createTextNode')
@DomName('Document.createTextNode')
@@ -9982,12 +9982,12 @@ abstract class Element extends Node implements ParentNode, ChildNode native "Ele
@JSName('getAttribute')
@DomName('Element.getAttribute')
@DocsEditable()
- String $dom_getAttribute(String name) native;
+ String _getAttribute(String name) native;
@JSName('getAttributeNS')
@DomName('Element.getAttributeNS')
@DocsEditable()
- String $dom_getAttributeNS(String namespaceURI, String localName) native;
+ String _getAttributeNS(String namespaceURI, String localName) native;
@DomName('Element.getBoundingClientRect')
@DocsEditable()
@@ -10091,12 +10091,12 @@ abstract class Element extends Node implements ParentNode, ChildNode native "Ele
@JSName('setAttribute')
@DomName('Element.setAttribute')
@DocsEditable()
- void $dom_setAttribute(String name, String value) native;
+ void _setAttribute(String name, String value) native;
@JSName('setAttributeNS')
@DomName('Element.setAttributeNS')
@DocsEditable()
- void $dom_setAttributeNS(String namespaceURI, String qualifiedName, String value) native;
+ void _setAttributeNS(String namespaceURI, String qualifiedName, String value) native;
@JSName('webkitGetRegionFlowRanges')
@DomName('Element.webkitGetRegionFlowRanges')
@@ -17444,7 +17444,7 @@ class _ChildNodeListLazy extends ListBase<Node> {
_this._replaceChild(value, this[index]);
}
- Iterator<Node> get iterator => _this.$dom_childNodes.iterator;
+ Iterator<Node> get iterator => _this._childNodes.iterator;
// From List<Node>:
@@ -17466,15 +17466,15 @@ class _ChildNodeListLazy extends ListBase<Node> {
// -- end List<Node> mixins.
// TODO(jacobr): benchmark whether this is more efficient or whether caching
- // a local copy of $dom_childNodes is more efficient.
- int get length => _this.$dom_childNodes.length;
+ // a local copy of _childNodes is more efficient.
+ int get length => _this._childNodes.length;
void set length(int value) {
throw new UnsupportedError(
"Cannot set length on immutable List.");
}
- Node operator[](int index) => _this.$dom_childNodes[index];
+ Node operator[](int index) => _this._childNodes[index];
}
/** Information about the instantiated template. */
@@ -17673,7 +17673,7 @@ class Node extends EventTarget native "Node" {
@DocsEditable()
@Returns('NodeList')
@Creates('NodeList')
- final List<Node> $dom_childNodes;
+ final List<Node> _childNodes;
@DomName('Node.firstChild')
@DocsEditable()
@@ -19361,7 +19361,7 @@ typedef void RtcStatsCallback(RtcStatsResponse response);
@DomName('Range')
@Unstable()
class Range extends Interceptor native "Range" {
- factory Range() => document.$dom_createRange();
+ factory Range() => document._createRange();
factory Range.fromPoint(Point point) =>
document._caretRangeFromPoint(point.x, point.y);
@@ -27307,15 +27307,15 @@ class _ElementAttributeMap extends _AttributeMap {
}
String operator [](String key) {
- return _element.$dom_getAttribute(key);
+ return _element._getAttribute(key);
}
void operator []=(String key, String value) {
- _element.$dom_setAttribute(key, value);
+ _element._setAttribute(key, value);
}
String remove(String key) {
- String value = _element.$dom_getAttribute(key);
+ String value = _element._getAttribute(key);
_element._removeAttribute(key);
return value;
}
@@ -27344,11 +27344,11 @@ class _NamespacedAttributeMap extends _AttributeMap {
}
String operator [](String key) {
- return _element.$dom_getAttributeNS(_namespace, key);
+ return _element._getAttributeNS(_namespace, key);
}
void operator []=(String key, String value) {
- _element.$dom_setAttributeNS(_namespace, key, value);
+ _element._setAttributeNS(_namespace, key, value);
}
String remove(String key) {

Powered by Google App Engine
This is Rietveld 408576698