Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1828)

Unified Diff: tools/dom/src/native_DOMImplementation.dart

Issue 23189009: Modify custom elements to inherit from HtmlElement (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart
Patch Set: Regenerate dart:html Created 7 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « tests/html/custom_elements_test.dart ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: tools/dom/src/native_DOMImplementation.dart
diff --git a/tools/dom/src/native_DOMImplementation.dart b/tools/dom/src/native_DOMImplementation.dart
index 8cdf24d8e3edc1a85b4d60aad7253bdcede07677..5b4f1e4cfa650cf2d6c16ddd6fff6db33e2ed8f0 100644
--- a/tools/dom/src/native_DOMImplementation.dart
+++ b/tools/dom/src/native_DOMImplementation.dart
@@ -211,7 +211,8 @@ class _Utils {
Symbol objectName = reflectClass(Object).qualifiedName;
bool isRoot(ClassMirror cls) =>
cls == null || cls.qualifiedName == objectName;
- Symbol elementName = reflectClass(Element).qualifiedName;
+ // TODO(vsm): Support extending SvgElement as well.
+ Symbol elementName = reflectClass(HtmlElement).qualifiedName;
bool isElement(ClassMirror cls) =>
cls != null && cls.qualifiedName == elementName;
@@ -220,7 +221,7 @@ class _Utils {
}
if (isRoot(superClass)) {
- throw new UnsupportedError("Invalid custom element doesn't inherit from Element.");
+ throw new UnsupportedError("Invalid custom element doesn't inherit from HtmlElement.");
}
_register(tag, type);
}
« no previous file with comments | « tests/html/custom_elements_test.dart ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698