third_party/WebKit/Source/platform/v8_inspector/V8RuntimeAgentImpl.h - Issue 2318853002: [DevTools] Handle navigation in console.log

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/platform/v8_inspector/V8RuntimeAgentImpl.h

Issue 2318853002: [DevTools] Handle navigation in console.log (Closed)

Patch Set: addressed comments Created 4 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« third_party/WebKit/LayoutTests/inspector-protocol/runtime/runtime-console-log-handle-navigate-expected.txt ('K') | « third_party/WebKit/Source/platform/v8_inspector/V8InspectorImpl.cpp ('k') | third_party/WebKit/Source/platform/v8_inspector/V8RuntimeAgentImpl.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/platform/v8_inspector/V8RuntimeAgentImpl.h

diff --git a/third_party/WebKit/Source/platform/v8_inspector/V8RuntimeAgentImpl.h b/third_party/WebKit/Source/platform/v8_inspector/V8RuntimeAgentImpl.h

index 7a14224ef8e8d7919e25b0d40cda9f9c6e964a74..e5d7d1e802266fa1dfa9b74a7d0ac1cf14253e70 100644

--- a/third_party/WebKit/Source/platform/v8_inspector/V8RuntimeAgentImpl.h

+++ b/third_party/WebKit/Source/platform/v8_inspector/V8RuntimeAgentImpl.h

@@ -124,7 +124,7 @@ public:

bool enabled() const { return m_enabled; }

private:

- void reportMessage(V8ConsoleMessage*, bool generatePreview);

+ bool reportMessage(V8ConsoleMessage*, bool generatePreview);

V8InspectorSessionImpl* m_session;

protocol::DictionaryValue* m_state;