third_party/WebKit/Source/platform/v8_inspector/V8ConsoleAgentImpl.cpp - Issue 2318853002: [DevTools] Handle navigation in console.log

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/platform/v8_inspector/V8ConsoleAgentImpl.cpp

Issue 2318853002: [DevTools] Handle navigation in console.log (Closed)

Patch Set: Created 4 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« third_party/WebKit/LayoutTests/inspector-protocol/runtime/runtime-console-log-wont-crash.html ('K') | « third_party/WebKit/Source/platform/v8_inspector/InjectedScript.cpp ('k') | third_party/WebKit/Source/platform/v8_inspector/V8ConsoleMessage.cpp » ('j') | third_party/WebKit/Source/platform/v8_inspector/V8ConsoleMessage.cpp » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/platform/v8_inspector/V8ConsoleAgentImpl.cpp

diff --git a/third_party/WebKit/Source/platform/v8_inspector/V8ConsoleAgentImpl.cpp b/third_party/WebKit/Source/platform/v8_inspector/V8ConsoleAgentImpl.cpp

index 9ab15efb77fabf55e063572a53a28984b9811ee2..60b54e7ed0e928d3430b048da5a9130928f85ec3 100644

--- a/third_party/WebKit/Source/platform/v8_inspector/V8ConsoleAgentImpl.cpp

+++ b/third_party/WebKit/Source/platform/v8_inspector/V8ConsoleAgentImpl.cpp

@@ -76,6 +76,8 @@ void V8ConsoleAgentImpl::reportAllMessages()

for (const auto& message : storage->messages()) {

if (message->origin() == V8MessageOrigin::kConsole)

reportMessage(message.get(), false);

+ if (!m_session->inspector()->hasConsoleMessageStorage(m_session->contextGroupId()))

dgozman 2016/09/07 00:21:03 if (!reportMessage(...)) return;

kozy 2016/09/07 00:50:16 Done.

+ return;

}