third_party/WebKit/Source/platform/v8_inspector/V8ConsoleAgentImpl.h - Issue 2318853002: [DevTools] Handle navigation in console.log

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: third_party/WebKit/Source/platform/v8_inspector/V8ConsoleAgentImpl.h

Issue 2318853002: [DevTools] Handle navigation in console.log (Closed)

Patch Set: addressed comments Created 4 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

« third_party/WebKit/LayoutTests/inspector-protocol/runtime/runtime-console-log-handle-navigate-expected.txt ('K') | « third_party/WebKit/Source/platform/v8_inspector/InjectedScript.cpp ('k') | third_party/WebKit/Source/platform/v8_inspector/V8ConsoleAgentImpl.cpp » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

OLD	NEW
1 // Copyright 2016 The Chromium Authors. All rights reserved.	1 // Copyright 2016 The Chromium Authors. All rights reserved.

2 // Use of this source code is governed by a BSD-style license that can be	2 // Use of this source code is governed by a BSD-style license that can be

3 // found in the LICENSE file.	3 // found in the LICENSE file.

4	4

5 #ifndef V8ConsoleAgentImpl_h	5 #ifndef V8ConsoleAgentImpl_h

6 #define V8ConsoleAgentImpl_h	6 #define V8ConsoleAgentImpl_h

7	7

8 #include "platform/v8_inspector/Allocator.h"	8 #include "platform/v8_inspector/Allocator.h"

9 #include "platform/v8_inspector/protocol/Console.h"	9 #include "platform/v8_inspector/protocol/Console.h"

10 #include "platform/v8_inspector/protocol/Forward.h"	10 #include "platform/v8_inspector/protocol/Forward.h"

(...skipping 15 matching lines...) Expand all Loading...
26 void disable(ErrorString*) override;	26 void disable(ErrorString*) override;

27 void clearMessages(ErrorString*) override;	27 void clearMessages(ErrorString*) override;

28	28

29 void restore();	29 void restore();

30 void messageAdded(V8ConsoleMessage*);	30 void messageAdded(V8ConsoleMessage*);

31 void reset();	31 void reset();

32 bool enabled();	32 bool enabled();

33	33

34 private:	34 private:

35 void reportAllMessages();	35 void reportAllMessages();

36 void reportMessage(V8ConsoleMessage*, bool generatePreview);	36 bool reportMessage(V8ConsoleMessage*, bool generatePreview);

37	37

38 V8InspectorSessionImpl* m_session;	38 V8InspectorSessionImpl* m_session;

39 protocol::DictionaryValue* m_state;	39 protocol::DictionaryValue* m_state;

40 protocol::Console::Frontend m_frontend;	40 protocol::Console::Frontend m_frontend;

41 bool m_enabled;	41 bool m_enabled;

42 };	42 };

43	43

44 } // namespace v8_inspector	44 } // namespace v8_inspector

45	45

46	46

47 #endif // !defined(V8ConsoleAgentImpl_h)	47 #endif // !defined(V8ConsoleAgentImpl_h)

OLD	NEW