Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(489)

Side by Side Diff: third_party/WebKit/Source/platform/v8_inspector/V8ConsoleAgentImpl.cpp

Issue 2318853002: [DevTools] Handle navigation in console.log (Closed)
Patch Set: addressed comments Created 4 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright 2016 The Chromium Authors. All rights reserved. 1 // Copyright 2016 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "platform/v8_inspector/V8ConsoleAgentImpl.h" 5 #include "platform/v8_inspector/V8ConsoleAgentImpl.h"
6 6
7 #include "platform/v8_inspector/V8ConsoleMessage.h" 7 #include "platform/v8_inspector/V8ConsoleMessage.h"
8 #include "platform/v8_inspector/V8InspectorImpl.h" 8 #include "platform/v8_inspector/V8InspectorImpl.h"
9 #include "platform/v8_inspector/V8InspectorSessionImpl.h" 9 #include "platform/v8_inspector/V8InspectorSessionImpl.h"
10 #include "platform/v8_inspector/V8StackTraceImpl.h" 10 #include "platform/v8_inspector/V8StackTraceImpl.h"
(...skipping 56 matching lines...) Expand 10 before | Expand all | Expand 10 after
67 67
68 bool V8ConsoleAgentImpl::enabled() 68 bool V8ConsoleAgentImpl::enabled()
69 { 69 {
70 return m_enabled; 70 return m_enabled;
71 } 71 }
72 72
73 void V8ConsoleAgentImpl::reportAllMessages() 73 void V8ConsoleAgentImpl::reportAllMessages()
74 { 74 {
75 V8ConsoleMessageStorage* storage = m_session->inspector()->ensureConsoleMess ageStorage(m_session->contextGroupId()); 75 V8ConsoleMessageStorage* storage = m_session->inspector()->ensureConsoleMess ageStorage(m_session->contextGroupId());
76 for (const auto& message : storage->messages()) { 76 for (const auto& message : storage->messages()) {
77 if (message->origin() == V8MessageOrigin::kConsole) 77 if (message->origin() == V8MessageOrigin::kConsole) {
78 reportMessage(message.get(), false); 78 if (!reportMessage(message.get(), false))
79 return;
80 }
79 } 81 }
80 } 82 }
81 83
82 void V8ConsoleAgentImpl::reportMessage(V8ConsoleMessage* message, bool generateP review) 84 bool V8ConsoleAgentImpl::reportMessage(V8ConsoleMessage* message, bool generateP review)
83 { 85 {
84 DCHECK(message->origin() == V8MessageOrigin::kConsole); 86 DCHECK(message->origin() == V8MessageOrigin::kConsole);
85 message->reportToFrontend(&m_frontend); 87 message->reportToFrontend(&m_frontend);
86 m_frontend.flush(); 88 m_frontend.flush();
89 return m_session->inspector()->hasConsoleMessageStorage(m_session->contextGr oupId());
87 } 90 }
88 91
89 } // namespace v8_inspector 92 } // namespace v8_inspector
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698