src/ic.cc - Issue 231883007: Return MaybeHandle from Invoke.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/ic.cc

Issue 231883007: Return MaybeHandle from Invoke. (Closed) Base URL: https://v8.googlecode.com/svn/branches/bleeding_edge

Patch Set: Created 6 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: src/ic.cc

diff --git a/src/ic.cc b/src/ic.cc

index 261d2e61580d7a79a41a5043c989c98cc482eacd..507b9211807872a2f602630fc96ee59fdebc8598 100644

--- a/src/ic.cc

+++ b/src/ic.cc

@@ -2397,10 +2397,10 @@ MaybeObject* BinaryOpIC::Transition(Handle<AllocationSite> allocation_site,

Object* builtin = isolate()->js_builtins_object()->javascript_builtin(

TokenToJSBuiltin(state.op()));

Handle<JSFunction> function = handle(JSFunction::cast(builtin), isolate());

- bool caught_exception;

- Handle<Object> result = Execution::Call(

- isolate(), function, left, 1, &right, &caught_exception);

- if (caught_exception) return Failure::Exception();

+ Handle<Object> result;

+ ASSIGN_RETURN_FAILURE_ON_EXCEPTION(

+ isolate(), result,

+ Execution::Call(isolate(), function, left, 1, &right));

// Execution::Call can execute arbitrary JavaScript, hence potentially

// update the state of this very IC, so we must update the stored state.

« no previous file with comments | « src/handles.cc ('k') | src/isolate.cc » ('j') | no next file with comments »