Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(864)

Unified Diff: chrome/renderer/pepper/pepper_extensions_common_host.cc

Issue 231883002: Refactor some ResourceMessageReply usages. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Use ReplyMessageContext.is_valid() method. Created 6 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/renderer/pepper/pepper_extensions_common_host.cc
diff --git a/chrome/renderer/pepper/pepper_extensions_common_host.cc b/chrome/renderer/pepper/pepper_extensions_common_host.cc
index 754c497d67a42bc7de4a262d811158c2532bb913..3397a1420d0405e10de38897e0103f5b3f78c6f9 100644
--- a/chrome/renderer/pepper/pepper_extensions_common_host.cc
+++ b/chrome/renderer/pepper/pepper_extensions_common_host.cc
@@ -84,12 +84,13 @@ int32_t PepperExtensionsCommonHost::OnResourceMessageReceived(
}
void PepperExtensionsCommonHost::OnResponseReceived(
- scoped_ptr<ppapi::host::ReplyMessageContext> context,
+ const ppapi::host::ReplyMessageContext& reply_context,
bool success,
const base::ListValue& response,
const std::string& /* error */) {
- context->params.set_result(success ? PP_OK : PP_ERROR_FAILED);
- SendReply(*context, PpapiPluginMsg_ExtensionsCommon_CallReply(response));
+ ppapi::host::ReplyMessageContext context(reply_context);
+ context.params.set_result(success ? PP_OK : PP_ERROR_FAILED);
+ SendReply(context, PpapiPluginMsg_ExtensionsCommon_CallReply(response));
}
int32_t PepperExtensionsCommonHost::OnPost(
@@ -107,12 +108,10 @@ int32_t PepperExtensionsCommonHost::OnCall(
const std::string& request_name,
const base::ListValue& args) {
std::string error;
- scoped_ptr<ppapi::host::ReplyMessageContext> message_context(
- new ppapi::host::ReplyMessageContext(context->MakeReplyMessageContext()));
bool success = pepper_request_proxy_->StartRequest(
base::Bind(&PepperExtensionsCommonHost::OnResponseReceived,
weak_factory_.GetWeakPtr(),
- base::Passed(&message_context)),
+ context->MakeReplyMessageContext()),
request_name,
args,
&error);

Powered by Google App Engine
This is Rietveld 408576698