Refactor some ResourceMessageReply usages.

content/renderer/pepper/pepper_device_enumeration_host_helper.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "content/renderer/pepper/pepper_device_enumeration_host_helper.h"
 
 #include "base/bind.h"
 #include "base/logging.h"
 #include "base/memory/weak_ptr.h"
 #include "base/message_loop/message_loop.h"
@@ skipping 117 matching lines @@
         PpapiHostMsg_DeviceEnumeration_StopMonitoringDeviceChange,
         OnStopMonitoringDeviceChange)
   IPC_END_MESSAGE_MAP()
 
   *handled = false;
   return PP_ERROR_FAILED;
 }
 
 int32_t PepperDeviceEnumerationHostHelper::OnEnumerateDevices(
     HostMessageContext* context) {
-  if (enumerate_devices_context_)
+  if (enumerate_devices_context_.is_valid())
     return PP_ERROR_INPROGRESS;
 
   enumerate_.reset(new ScopedRequest(
       this,
       base::Bind(&PepperDeviceEnumerationHostHelper::OnEnumerateDevicesComplete,
                  base::Unretained(this))));
   if (!enumerate_->requested())
     return PP_ERROR_FAILED;
 
-  enumerate_devices_context_.reset(
-      new ppapi::host::ReplyMessageContext(context->MakeReplyMessageContext()));
+  enumerate_devices_context_ = context->MakeReplyMessageContext();
   return PP_OK_COMPLETIONPENDING;
 }
 
 int32_t PepperDeviceEnumerationHostHelper::OnMonitorDeviceChange(
     HostMessageContext* /* context */,
     uint32_t callback_id) {
   monitor_.reset(new ScopedRequest(
       this,
       base::Bind(&PepperDeviceEnumerationHostHelper::OnNotifyDeviceChange,
                  base::Unretained(this), callback_id)));
 
   return monitor_->requested() ? PP_OK : PP_ERROR_FAILED;
 }
 
 int32_t PepperDeviceEnumerationHostHelper::OnStopMonitoringDeviceChange(
     HostMessageContext* /* context */) {
   monitor_.reset(NULL);
   return PP_OK;
 }
 
 void PepperDeviceEnumerationHostHelper::OnEnumerateDevicesComplete(
     int /* request_id */,
     const std::vector<ppapi::DeviceRefData>& devices) {
-  DCHECK(enumerate_devices_context_.get());
+  DCHECK(enumerate_devices_context_.is_valid());
 
   enumerate_.reset(NULL);
 
-  enumerate_devices_context_->params.set_result(PP_OK);
+  enumerate_devices_context_.params.set_result(PP_OK);
   resource_host_->host()->SendReply(
-      *enumerate_devices_context_,
+      enumerate_devices_context_,
       PpapiPluginMsg_DeviceEnumeration_EnumerateDevicesReply(devices));
-  enumerate_devices_context_.reset();
+  enumerate_devices_context_ = ppapi::host::ReplyMessageContext();

[dmichael (off chromium), 2014/04/11 20:56:14]

optional: you could alternatively have a "clear()" method. 

[bbudge, 2014/04/11 22:46:05]

Going through RMC usage and copying sounds like a good Noogler project in
Pepper.

 }
 
 void PepperDeviceEnumerationHostHelper::OnNotifyDeviceChange(
     uint32_t callback_id,
     int /* request_id */,
     const std::vector<ppapi::DeviceRefData>& devices) {
   resource_host_->host()->SendUnsolicitedReply(
       resource_host_->pp_resource(),
       PpapiPluginMsg_DeviceEnumeration_NotifyDeviceChange(
           callback_id,
           devices));
 }
 
 }  // namespace content