Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(853)

Issue 2318753002: Fix GpuProcessTransportFactory destructor crash (Closed)

Created:
4 years, 3 months ago by enne (OOO)
Modified:
4 years, 3 months ago
Reviewers:
danakj
CC:
chromium-reviews, danakj+watch_chromium.org, darin-cc_chromium.org, jam, jbauman+watch_chromium.org, kalyank, piman+watch_chromium.org, sievers+watch_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Fix GpuProcessTransportFactory destructor crash https://codereview.chromium.org/2297473002 changed a raw pointer in GpuProcessTransportFactory into a unique_ptr, which caused some additional shutdown behavior (destroying map entries) that was not there before the patch. PerCompositorData depends on SurfaceManager existing (to unregister begin frame sources from ~Display). So, SurfaceManager's lifetime should exceed the lifetime of all Displays. BUG=642803 Committed: https://crrev.com/1a1031cf083156956a7b6f4934089281da6981c0 Cr-Commit-Position: refs/heads/master@{#416756}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+6 lines, -4 lines) Patch
M content/browser/compositor/gpu_process_transport_factory.h View 1 chunk +5 lines, -2 lines 0 comments Download
M content/browser/compositor/gpu_process_transport_factory.cc View 1 chunk +1 line, -2 lines 0 comments Download

Messages

Total messages: 11 (6 generated)
enne (OOO)
OOPS
4 years, 3 months ago (2016-09-06 20:56:21 UTC) #2
danakj
A++ LGTM
4 years, 3 months ago (2016-09-06 21:46:30 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2318753002/1
4 years, 3 months ago (2016-09-06 21:58:27 UTC) #8
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 3 months ago (2016-09-06 23:11:41 UTC) #9
commit-bot: I haz the power
4 years, 3 months ago (2016-09-06 23:14:51 UTC) #11
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/1a1031cf083156956a7b6f4934089281da6981c0
Cr-Commit-Position: refs/heads/master@{#416756}

Powered by Google App Engine
This is Rietveld 408576698