Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(69)

Issue 2318743002: Provide v8::Context to v8::ValueDeserializer::ReadHeader. (Closed)

Created:
4 years, 3 months ago by jbroman
Modified:
4 years, 3 months ago
CC:
blink-reviews, blink-reviews-bindings_chromium.org, chromium-reviews, jbroman+watch_chromium.org, Michael Hablich
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Provide v8::Context to v8::ValueDeserializer::ReadHeader. Since it can now throw exceptions, it should be explicitly given a context in which to do so. This allows the no-argument version to be removed from V8. BUG=chromium:148757, chromium:641964 Committed: https://crrev.com/a1e7daa60cb845a89dd455f9d363afb6e929cfe1 Cr-Commit-Position: refs/heads/master@{#416810}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M third_party/WebKit/Source/bindings/core/v8/serialization/V8ScriptValueDeserializer.cpp View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 14 (8 generated)
jbroman
4 years, 3 months ago (2016-09-06 20:42:18 UTC) #3
haraken
LGTM
4 years, 3 months ago (2016-09-07 00:21:26 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2318743002/1
4 years, 3 months ago (2016-09-07 01:03:58 UTC) #9
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 3 months ago (2016-09-07 01:08:00 UTC) #10
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/a1e7daa60cb845a89dd455f9d363afb6e929cfe1 Cr-Commit-Position: refs/heads/master@{#416810}
4 years, 3 months ago (2016-09-07 01:09:57 UTC) #12
Michael Achenbach
4 years, 3 months ago (2016-09-07 06:25:51 UTC) #14
Message was sent while issue was closed.
FYI: This changes builds upon something that just landed in V8 short time ago.
Please generally keep a bigger window between V8 and dependent changes, so that
we have a stable API for the duration of at least one canary. Too small windows
are signaled here:
https://build.chromium.org/p/chromium.fyi/builders/Linux%20V8%20API%20Stabili...

This can lead to conflicts in case of a V8 canary revert.

Powered by Google App Engine
This is Rietveld 408576698