Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(72)

Issue 2318713004: Fix undefined behavior in base/numerics (Closed)

Created:
4 years, 3 months ago by jschuh
Modified:
4 years, 3 months ago
Reviewers:
Tom Sepez
CC:
chromium-reviews
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Fix undefined behavior in base/numerics BUG=643585 R=tsepez@chromium.org Committed: https://crrev.com/749c7f7733ccb09a60eb531f76551f7d709e1bda Cr-Commit-Position: refs/heads/master@{#416954}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+17 lines, -13 lines) Patch
M base/numerics/safe_math_impl.h View 6 chunks +7 lines, -7 lines 0 comments Download
M base/numerics/safe_numerics_unittest.cc View 2 chunks +10 lines, -6 lines 0 comments Download

Messages

Total messages: 10 (6 generated)
Tom Sepez
lgtm
4 years, 3 months ago (2016-09-07 16:04:51 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2318713004/1
4 years, 3 months ago (2016-09-07 16:18:12 UTC) #7
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 3 months ago (2016-09-07 16:22:42 UTC) #8
commit-bot: I haz the power
4 years, 3 months ago (2016-09-07 16:26:09 UTC) #10
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/749c7f7733ccb09a60eb531f76551f7d709e1bda
Cr-Commit-Position: refs/heads/master@{#416954}

Powered by Google App Engine
This is Rietveld 408576698