Source/core/page/Settings.in - Issue 23187005: [DevTools] Use device metrics emulation implemented in content.

Side by Side Diff: Source/core/page/Settings.in

Issue 23187005: [DevTools] Use device metrics emulation implemented in content. (Closed) Base URL: svn://svn.chromium.org/blink/trunk/

Patch Set: Reupload Created 7 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch | Annotate | Revision Log

« Source/core/page/FrameView.cpp ('K') | « Source/core/page/Screen.cpp ('k') | Source/core/platform/ScrollView.h » ('j') | Source/web/WebDevToolsAgentImpl.cpp » ('J')

OLD	NEW
1 # FIXME: Add support for global settings.	1 # FIXME: Add support for global settings.

2 # FIXME: Add support for custom getters/setters.	2 # FIXME: Add support for custom getters/setters.

3	3

4 defaultTextEncodingName type=String	4 defaultTextEncodingName type=String

5 editableLinkBehavior type=EditableLinkBehavior, initial=EditableLinkDefaultBehav ior	5 editableLinkBehavior type=EditableLinkBehavior, initial=EditableLinkDefaultBehav ior

6 passwordEchoDurationInSeconds type=double, initial=1	6 passwordEchoDurationInSeconds type=double, initial=1

7	7

8 # Sets the magnification value for validation message timer. If the	8 # Sets the magnification value for validation message timer. If the

9 # magnification value is N, a validation message disappears automatically after	9 # magnification value is N, a validation message disappears automatically after

10 # <message length> * N / 1000 seconds. If N is equal to or less than 0, a	10 # <message length> * N / 1000 seconds. If N is equal to or less than 0, a

(...skipping 132 matching lines...) Expand 10 before \| Expand all \| Expand 10 after Loading...
143 # It will be possible to remove it once WebSettings.{get\|set}UseWideViewPort	143 # It will be possible to remove it once WebSettings.{get\|set}UseWideViewPort

144 # API function will be removed. See http://crbug.com/288037.	144 # API function will be removed. See http://crbug.com/288037.

145 wideViewportQuirkEnabled initial=false	145 wideViewportQuirkEnabled initial=false

146	146

147 # This setting enables touch based text selection and editing.	147 # This setting enables touch based text selection and editing.

148 touchEditingEnabled initial=false	148 touchEditingEnabled initial=false

149	149

150 experimentalWebSocketEnabled initial=false	150 experimentalWebSocketEnabled initial=false

151 pinchVirtualViewportEnabled initial=false	151 pinchVirtualViewportEnabled initial=false

152 useSolidColorScrollbars initial=false	152 useSolidColorScrollbars initial=false

	153

	154 rootLayerClipsContent initial=true
	aelias_OOO_until_Jul13 2013/10/01 08:08:51 If your Blink patch lands first, it will break And If your Blink patch lands first, it will break Android until the Chromium side lands (Android requires the clip to be disabled, other platforms don't care one way or the other). To avoid that situation I recommend setting the default to false, and set it to true on non-Android on the Chromium side. I also recommend setting the layout test expectations I touched in https://chromiumcodereview.appspot.com/19019004 as NeedsManualRebaseline, as they'll break again when the setting goes to true on desktop platforms. dgozman 2013/10/01 15:26:34 I will first land API change (https://codereview.c Show quoted text On 2013/10/01 08:08:51, aelias wrote: > If your Blink patch lands first, it will break Android until the Chromium side > lands (Android requires the clip to be disabled, other platforms don't care one > way or the other). To avoid that situation I recommend setting the default to > false, and set it to true on non-Android on the Chromium side. > > I also recommend setting the layout test expectations I touched in > https://chromiumcodereview.appspot.com/19019004 as NeedsManualRebaseline, as > they'll break again when the setting goes to true on desktop platforms. I will first land API change (https://codereview.chromium.org/24272003/), with setting introduced there. Then chromium-side change, which will set it to false on Android. And only after that this change, which uses it. Thank for layout test expectations tip!
OLD	NEW