[DevTools] Use device metrics emulation implemented in content.

Source/web/WebDevToolsAgentImpl.cpp

 /*
  * Copyright (C) 2010-2011 Google Inc. All rights reserved.
  *
  * Redistribution and use in source and binary forms, with or without
  * modification, are permitted provided that the following conditions are
  * met:
  *
  *     * Redistributions of source code must retain the above copyright
  * notice, this list of conditions and the following disclaimer.
  *     * Redistributions in binary form must reproduce the above
@@ skipping 16 matching lines @@
  * (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY OUT OF THE USE
  * OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE.
  */
 
 #include "config.h"
 #include "WebDevToolsAgentImpl.h"
 
 #include "InspectorBackendDispatcher.h"
 #include "InspectorFrontend.h"
 #include "InspectorProtocolVersion.h"
+#include "RuntimeEnabledFeatures.h"
 #include "WebDataSource.h"
 #include "WebDevToolsAgentClient.h"
 #include "WebFrameImpl.h"
 #include "WebInputEventConversion.h"
 #include "WebMemoryUsageInfo.h"
+#include "WebSettings.h"
 #include "WebViewClient.h"
 #include "WebViewImpl.h"
 #include "bindings/v8/PageScriptDebugServer.h"
 #include "bindings/v8/ScriptController.h"
 #include "bindings/v8/V8Binding.h"
 #include "bindings/v8/V8Utilities.h"
 #include "core/dom/ExceptionCode.h"
 #include "core/fetch/MemoryCache.h"
 #include "core/inspector/InjectedScriptHost.h"
 #include "core/inspector/InspectorController.h"
 #include "core/page/Frame.h"
 #include "core/page/FrameView.h"
 #include "core/page/Page.h"
 #include "core/page/PageGroup.h"
+#include "core/page/Settings.h"
 #include "core/platform/JSONValues.h"
 #include "core/platform/graphics/GraphicsContext.h"
 #include "core/platform/network/ResourceError.h"
 #include "core/platform/network/ResourceRequest.h"
 #include "core/platform/network/ResourceResponse.h"
 #include "core/rendering/RenderView.h"
 #include "public/platform/Platform.h"
 #include "public/platform/WebRect.h"
 #include "public/platform/WebString.h"
 #include "public/platform/WebURL.h"
@@ skipping 114 matching lines @@
     virtual void run()
     {
         if (WebDevToolsAgent* webagent = m_descriptor->agent())
             webagent->dispatchOnInspectorBackend(m_descriptor->message());
     }
 
 private:
     OwnPtr<WebDevToolsAgent::MessageDescriptor> m_descriptor;
 };
 
+// FIXME: remove DeviceMetricsSupport.

[pfeldman, 2013/09/19 12:46:05]

Do it right away.

 class DeviceMetricsSupport {
 public:
     DeviceMetricsSupport(WebViewImpl* webView)
         : m_webView(webView)
         , m_fitWindow(false)
         , m_originalZoomFactor(0)
     {
     }
 
     ~DeviceMetricsSupport()
@@ skipping 151 matching lines @@
     double m_originalZoomFactor;
 };
 
 WebDevToolsAgentImpl::WebDevToolsAgentImpl(
     WebViewImpl* webViewImpl,
     WebDevToolsAgentClient* client)
     : m_hostId(client->hostIdentifier())
     , m_client(client)
     , m_webViewImpl(webViewImpl)
     , m_attached(false)
+    , m_deviceMetricsEnabled(false)

[pfeldman, 2013/09/19 12:46:05]

You need to initialize all booleans here.

[dgozman, 2013/09/19 13:59:38]

Done.

 {
     ASSERT(m_hostId > 0);
     ClientMessageLoopAdapter::ensureClientMessageLoopCreated(m_client);
 }
 
 WebDevToolsAgentImpl::~WebDevToolsAgentImpl()
 {
     ClientMessageLoopAdapter::inspectedViewClosed(m_webViewImpl);
     if (m_attached)
         WebKit::Platform::current()->currentThread()->removeTaskObserver(this);
@@ skipping 70 matching lines @@
 }
 
 void WebDevToolsAgentImpl::mainFrameViewCreated(WebFrameImpl* webFrame)
 {
     if (m_metricsSupport)
         m_metricsSupport->applySizeOverrideIfNecessary();
 }
 
 bool WebDevToolsAgentImpl::metricsOverridden()
 {
-    return !!m_metricsSupport;
+    // FIXME: cleanup usages of this function and remove it.

[pfeldman, 2013/09/19 12:46:05]

ditto

+    return false;
 }
 
 void WebDevToolsAgentImpl::webViewResized(const WebSize& size)
 {
     if (m_metricsSupport)
         m_metricsSupport->webViewResized();
     if (InspectorController* ic = inspectorController())
         ic->webViewResized(m_metricsSupport ? IntSize(size.width, size.height) : IntSize());
 }
 
@@ skipping 18 matching lines @@
     }
     if (WebInputEvent::isTouchEventType(inputEvent.type)) {
         PlatformTouchEvent touchEvent = PlatformTouchEventBuilder(page->mainFrame()->view(), *static_cast<const WebTouchEvent*>(&inputEvent));
         return ic->handleTouchEvent(page->mainFrame(), touchEvent);
     }
     return false;
 }
 
 void WebDevToolsAgentImpl::overrideDeviceMetrics(int width, int height, float fontScaleFactor, bool fitWindow)
 {
+    // FIXME: enable viewport after UI problems with pageScaleFactor will be fixed.
+    bool enableViewport = false;
+
+    bool needReload = false;
     if (!width && !height) {
-        if (m_metricsSupport)
-            m_metricsSupport.clear();
-        if (InspectorController* ic = inspectorController())
-            ic->webViewResized(IntSize());
-        return;
+        if (m_deviceMetricsEnabled) {
+            needReload = true;
+            RuntimeEnabledFeatures::setOverlayScrollbarsEnabled(m_isOverlayScrollbarsEnabled);
+            if (enableViewport) {
+                RuntimeEnabledFeatures::setCSSViewportEnabled(m_isCSSViewportEnabled);
+                m_webViewImpl->enableFixedLayoutMode(false);
+                m_webViewImpl->settings()->setViewportEnabled(false);
+                m_webViewImpl->page()->settings().setTextAutosizingEnabled(false);
+                m_webViewImpl->setIgnoreViewportTagScaleLimits(false);
+                m_webViewImpl->setPageScaleFactorLimits(1.f, 1.f);

[apavlov, 2013/09/19 12:47:57]

Is the float literal notation really required here and below? I've seen it
disproved whenever implicit casts work...

[dgozman, 2013/09/19 13:59:38]

Done.

+            }
+            m_webViewImpl->client()->emulateDevice(false /* enabled */, IntSize(), IntRect(), 1.0f, false);
+        }
+        m_deviceMetricsEnabled = false;
+    } else {
+        if (!m_deviceMetricsEnabled) {
+            needReload = true;
+
+            m_isOverlayScrollbarsEnabled = RuntimeEnabledFeatures::overlayScrollbarsEnabled();
+            RuntimeEnabledFeatures::setOverlayScrollbarsEnabled(true);
+
+            if (enableViewport) {
+                m_isCSSViewportEnabled = RuntimeEnabledFeatures::cssViewportEnabled();
+                RuntimeEnabledFeatures::setCSSViewportEnabled(true);
+                // FIXME: save and restore next two values.

[apavlov, 2013/09/19 12:47:57]

Guess this comment should note that this should be done when enableViewport is
switched on.

[dgozman, 2013/09/19 13:59:38]

Nice catch! Thanks.

+                m_webViewImpl->enableFixedLayoutMode(true);
+                m_webViewImpl->settings()->setViewportEnabled(true);
+                m_webViewImpl->page()->settings().setTextAutosizingEnabled(true);

[apavlov, 2013/09/19 12:47:57]

This one is dubious. Text autosizing should be enabled only when emulating
Chrome. Blackberry, Android 2.3, and some other devices do not have Chrome.

[dgozman, 2013/09/19 13:59:38]

Safari, Firefox and IE has this functionality. Added a TODO to sort things out
when enabling viewport.

+                m_webViewImpl->setIgnoreViewportTagScaleLimits(fontScaleFactor > 1.f);
+                m_webViewImpl->setPageScaleFactorLimits(-1.f, -1.f);
+            }
+        }
+        if (enableViewport)
+            m_webViewImpl->page()->settings().setTextAutosizingFontScaleFactor(fontScaleFactor);
+
+        m_webViewImpl->client()->emulateDevice(true /* enabled */, IntSize(width, height), IntRect(0, 0, width, height), 2.0f, fitWindow);
+        m_deviceMetricsEnabled = true;
     }
+    if (needReload && m_webViewImpl->mainFrameImpl())
+        m_webViewImpl->mainFrameImpl()->reload(false /* ignoreCache */);
+}
 
-    if (!m_metricsSupport)
-        m_metricsSupport = adoptPtr(new DeviceMetricsSupport(m_webViewImpl));
-
-    m_metricsSupport->setDeviceMetrics(width, height, fontScaleFactor, fitWindow);
-    if (InspectorController* ic = inspectorController()) {
-        WebSize size = m_webViewImpl->size();
-        ic->webViewResized(IntSize(size.width, size.height));
-    }
+void WebDevToolsAgentImpl::setDeviceEmulationScales(bool enabled, float deviceScaleFactor, float rootLayerScale)
+{
+    m_webViewImpl->setDeviceEmulationScales(enabled, deviceScaleFactor, rootLayerScale);
 }
 
 void WebDevToolsAgentImpl::autoZoomPageToFitWidth()
 {
     if (m_metricsSupport)
         m_metricsSupport->autoZoomPageToFitWidthOnNavigation(m_webViewImpl->mainFrameImpl()->frame());
 }
 
 void WebDevToolsAgentImpl::getAllocatedObjects(HashSet<const void*>& set)
 {
@@ skipping 240 matching lines @@
         || commandName == InspectorBackendDispatcher::commandNames[InspectorBackendDispatcher::kProfiler_getCPUProfileCmd]
         || commandName == InspectorBackendDispatcher::commandNames[InspectorBackendDispatcher::kHeapProfiler_getHeapSnapshotCmd];
 }
 
 void WebDevToolsAgent::processPendingMessages()
 {
     PageScriptDebugServer::shared().runPendingTasks();
 }
 
 } // namespace WebKit