Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(463)

Issue 2318673004: dart2js: Inhibit code motion of indexing (Closed)

Created:
4 years, 3 months ago by sra1
Modified:
4 years, 3 months ago
CC:
reviews_dartlang.org
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Patch Set 1 #

Total comments: 1

Patch Set 2 : Add TODO #

Unified diffs Side-by-side diffs Delta from patch set Stats (+8 lines, -0 lines) Patch
M pkg/compiler/lib/src/ssa/nodes.dart View 1 2 chunks +8 lines, -0 lines 0 comments Download

Messages

Total messages: 5 (2 generated)
sra1
4 years, 3 months ago (2016-09-07 04:18:21 UTC) #2
Siggi Cherem (dart-lang)
lgtm https://codereview.chromium.org/2318673004/diff/1/pkg/compiler/lib/src/ssa/nodes.dart File pkg/compiler/lib/src/ssa/nodes.dart (right): https://codereview.chromium.org/2318673004/diff/1/pkg/compiler/lib/src/ssa/nodes.dart#newcode2626 pkg/compiler/lib/src/ssa/nodes.dart:2626: // Implicit dependency on HBoundsCheck or constraints on ...
4 years, 3 months ago (2016-09-07 14:27:01 UTC) #3
sra1
4 years, 3 months ago (2016-09-07 16:13:24 UTC) #5
Message was sent while issue was closed.
Committed patchset #2 (id:20001) manually as
74fee40234d73f738db8950b793460d0ae4399dd (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698