Issue 2318673004: dart2js: Inhibit code motion of indexing

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 2318673004: dart2js: Inhibit code motion of indexing (Closed)

Created:
4 years, 3 months ago by sra1

Modified:
4 years, 3 months ago

Reviewers:
Siggi Cherem (dart-lang)

CC:
reviews_dartlang.org

Target Ref:
refs/heads/master

Visibility:
Public.

More Reviews

Description

dart2js: Inhibit code motion of indexing R=sigmund@google.com Committed: https://github.com/dart-lang/sdk/commit/74fee40234d73f738db8950b793460d0ae4399dd

Patch Set 2 : Add TODO #

Created: 4 years, 3 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+8 lines, -0 lines)			Patch
	M	pkg/compiler/lib/src/ssa/nodes.dart	View	1	2 chunks	+8 lines, -0 lines	0 comments	Download

Messages

Total messages: 5 (2 generated)

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages

Siggi Cherem (dart-lang)

lgtm https://codereview.chromium.org/2318673004/diff/1/pkg/compiler/lib/src/ssa/nodes.dart File pkg/compiler/lib/src/ssa/nodes.dart (right): https://codereview.chromium.org/2318673004/diff/1/pkg/compiler/lib/src/ssa/nodes.dart#newcode2626 pkg/compiler/lib/src/ssa/nodes.dart:2626: // Implicit dependency on HBoundsCheck or constraints on ...

4 years, 3 months ago (2016-09-07 14:27:01 UTC) #3

sra1

4 years, 3 months ago (2016-09-07 16:13:24 UTC) #5

Message was sent while issue was closed.

Committed patchset #2 (id:20001) manually as
74fee40234d73f738db8950b793460d0ae4399dd (presubmit successful).

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages

Issue 2318673004: dart2js: Inhibit code motion of indexing (Closed)

Description

Patch Set 1 #

Patch Set 2 : Add TODO #

Messages