Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(426)

Issue 2318633002: Update Windows build to use VULKAN_SDK rather than VK_SDK_PATH (Closed)

Created:
4 years, 3 months ago by bsalomon
Modified:
4 years, 3 months ago
Reviewers:
jvanverth1, egdaniel
CC:
reviews_skia.org
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

Update Windows build to use VULKAN_SDK rather than VK_SDK_PATH BUG=skia: GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2318633002 Committed: https://skia.googlesource.com/skia/+/b2be02bb39351ed97e789f7d3e97c7180f72560f

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -3 lines) Patch
M gyp/gpu.gyp View 1 chunk +1 line, -1 line 0 comments Download
M infra/bots/recipe_modules/flavor/default_flavor.py View 1 chunk +1 line, -1 line 0 comments Download
M infra/bots/recipes/swarm_compile.expected/Build-Win-MSVC-x86_64-Release-Vulkan.json View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 8 (4 generated)
bsalomon
4 years, 3 months ago (2016-09-06 14:47:17 UTC) #3
egdaniel
lgtm. Will work as long as no one is using a very old version of ...
4 years, 3 months ago (2016-09-06 14:54:09 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2318633002/1
4 years, 3 months ago (2016-09-06 15:22:52 UTC) #6
commit-bot: I haz the power
4 years, 3 months ago (2016-09-06 15:40:54 UTC) #8
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://skia.googlesource.com/skia/+/b2be02bb39351ed97e789f7d3e97c7180f72560f

Powered by Google App Engine
This is Rietveld 408576698