Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(357)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 231863008: Rename SetDefaultSearchProvider. (Closed)

Created:
6 years, 8 months ago by erikwright (departed)
Modified:
6 years, 8 months ago
CC:
chromium-reviews, tim+watch_chromium.org, dbeam+watch-options_chromium.org, skanuj+watch_chromium.org, melevin+watch_chromium.org, dhollowa+watch_chromium.org, dougw+watch_chromium.org, donnd+watch_chromium.org, haitaol+watch_chromium.org, dominich, jfweitz+watch_chromium.org, David Black, samarth+watch_chromium.org, kmadhusu+watch_chromium.org, James Su, Jered, maniscalco+watch_chromium.org, gab, Cait (Slow)
Visibility:
Public.

Description

Rename SetDefaultSearchProvider to SetUserSelectedDefaultSearchProvider. This is the first step in making Preferences the authoritative source for the user-selected DSE. In follow-up CLs, we will only persist a DSE choice when it is an explicit user choice. BUG=365762 TBR=sky Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=266149

Patch Set 1 #

Patch Set 2 : Rebase. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+98 lines, -77 lines) Patch
M chrome/android/java/src/org/chromium/chrome/browser/search_engines/TemplateUrlService.java View 2 chunks +3 lines, -3 lines 0 comments Download
M chrome/browser/autocomplete/autocomplete_provider_unittest.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/autocomplete/history_quick_provider_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/autocomplete/history_url_provider_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/autocomplete/search_provider_unittest.cc View 1 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/autocomplete/shortcuts_backend_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/chrome_content_browser_client_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/profile_resetter/automatic_profile_resetter_delegate_unittest.cc View 2 chunks +3 lines, -2 lines 0 comments Download
M chrome/browser/search/instant_service_unittest.cc View 3 chunks +4 lines, -4 lines 0 comments Download
M chrome/browser/search/instant_unittest_base.h View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/search/instant_unittest_base.cc View 3 chunks +3 lines, -3 lines 0 comments Download
M chrome/browser/search/search_unittest.cc View 4 chunks +4 lines, -4 lines 0 comments Download
M chrome/browser/search_engines/search_provider_install_data_unittest.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/search_engines/template_url_service.h View 2 chunks +6 lines, -1 line 0 comments Download
M chrome/browser/search_engines/template_url_service.cc View 1 4 chunks +19 lines, -13 lines 0 comments Download
M chrome/browser/search_engines/template_url_service_android.h View 1 chunk +3 lines, -1 line 0 comments Download
M chrome/browser/search_engines/template_url_service_android.cc View 2 chunks +5 lines, -4 lines 0 comments Download
M chrome/browser/search_engines/template_url_service_sync_unittest.cc View 10 chunks +15 lines, -10 lines 0 comments Download
M chrome/browser/search_engines/template_url_service_unittest.cc View 1 9 chunks +9 lines, -9 lines 0 comments Download
M chrome/browser/sync/test/integration/search_engines_helper.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/browser/ui/browser_instant_controller_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/omnibox/omnibox_view_browsertest.cc View 1 3 chunks +3 lines, -3 lines 0 comments Download
M chrome/browser/ui/search/instant_test_utils.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/ui/search/search_ipc_router_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/search/search_tab_helper_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/search_engines/template_url_table_model.cc View 1 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/webui/options/browser_options_handler.cc View 1 1 chunk +2 lines, -1 line 0 comments Download

Messages

Total messages: 14 (0 generated)
erikwright (departed)
pkasting: PTAL. (Oops, didn't actually send)
6 years, 8 months ago (2014-04-23 18:03:26 UTC) #1
Peter Kasting
Rubber-stamp LGTM
6 years, 8 months ago (2014-04-23 18:43:29 UTC) #2
erikwright (departed)
TBR: sky for API name change.
6 years, 8 months ago (2014-04-24 18:27:30 UTC) #3
erikwright (departed)
The CQ bit was checked by erikwright@chromium.org
6 years, 8 months ago (2014-04-24 18:27:35 UTC) #4
erikwright (departed)
The CQ bit was unchecked by erikwright@chromium.org
6 years, 8 months ago (2014-04-24 19:32:12 UTC) #5
erikwright (departed)
The CQ bit was checked by erikwright@chromium.org
6 years, 8 months ago (2014-04-24 19:32:15 UTC) #6
Cait (Slow)
The CQ bit was unchecked by caitkp@chromium.org
6 years, 8 months ago (2014-04-24 21:45:17 UTC) #7
Cait (Slow)
The CQ bit was checked by caitkp@chromium.org
6 years, 8 months ago (2014-04-24 21:45:24 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/erikwright@chromium.org/231863008/30001
6 years, 8 months ago (2014-04-24 21:48:54 UTC) #9
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 8 months ago (2014-04-24 23:38:51 UTC) #10
commit-bot: I haz the power
Try jobs failed on following builders: tryserver.chromium on linux_chromium_chromeos_rel
6 years, 8 months ago (2014-04-24 23:38:52 UTC) #11
erikwright (departed)
The CQ bit was checked by erikwright@chromium.org
6 years, 8 months ago (2014-04-25 00:40:25 UTC) #12
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/erikwright@chromium.org/231863008/30001
6 years, 8 months ago (2014-04-25 00:40:57 UTC) #13
commit-bot: I haz the power
6 years, 8 months ago (2014-04-25 07:35:29 UTC) #14
Message was sent while issue was closed. 
Change committed as 266149

Powered by Google App Engine
This is Rietveld 408576698