Split Universe into ResolutionUniverse and CodegenUniverse

Split Universe into ResolutionUniverse and CodegenUniverse

Main changes in universe.dart

R=het@google.com, sigmund@google.com

Committed: https://github.com/dart-lang/sdk/commit/012229ec833a6f1a3922810fa966d6cd611fa99e

[Johnni Winther, 2016-09-06 13:36:03]

Description was changed from

==========
Split Universe into ResolutionUniverse and CodegenUniverse
==========

to

==========
Split Universe into ResolutionUniverse and CodegenUniverse

Main changes in universe.dart
==========

[Johnni Winther, 2016-09-06 13:36:10]

johnniwinther@google.com changed reviewers:
+ sigmund@google.com

[Siggi Cherem (dart-lang), 2016-09-06 17:57:43]

lgtm

https://codereview.chromium.org/2318593003/diff/1/pkg/compiler/lib/src/univer...
File pkg/compiler/lib/src/universe/universe.dart (right):

https://codereview.chromium.org/2318593003/diff/1/pkg/compiler/lib/src/univer...
pkg/compiler/lib/src/universe/universe.dart:156: // TODO(johnniwinther): Improve
semantic precision.
remove TODO (it's already in the impl class below)

https://codereview.chromium.org/2318593003/diff/1/pkg/compiler/lib/src/univer...
pkg/compiler/lib/src/universe/universe.dart:504: void
registerTypeInstantiation(InterfaceType type,
should some of this shared code be in a shared super class?


But let's not call it _BigBang....

  class CodegenUniverseImpl extends _BigBang { ... }

;-)

[Harry Terkelsen, 2016-09-19 18:07:09]

het@google.com changed reviewers:
+ het@google.com

[Harry Terkelsen, 2016-09-19 18:07:10]

lgtm

https://codereview.chromium.org/2318593003/diff/1/pkg/compiler/lib/src/compil...
File pkg/compiler/lib/src/compiler.dart (right):

https://codereview.chromium.org/2318593003/diff/1/pkg/compiler/lib/src/compil...
pkg/compiler/lib/src/compiler.dart:330: ResolutionUniverse get resolverWorld =>
enqueuer.resolution.universe;
also change the names to resolverUniverse and codegenUniverse?

https://codereview.chromium.org/2318593003/diff/1/pkg/compiler/lib/src/js_bac...
File pkg/compiler/lib/src/js_backend/enqueuer.dart (left):

https://codereview.chromium.org/2318593003/diff/1/pkg/compiler/lib/src/js_bac...
pkg/compiler/lib/src/js_backend/enqueuer.dart:572:
universe.callMethodsWithFreeTypeVariables.add(element);
where is this being registered now?

https://codereview.chromium.org/2318593003/diff/1/pkg/compiler/lib/src/univer...
File pkg/compiler/lib/src/universe/universe.dart (right):

https://codereview.chromium.org/2318593003/diff/1/pkg/compiler/lib/src/univer...
pkg/compiler/lib/src/universe/universe.dart:138: Set<Element> get
closuresWithFreeTypeVariables;
how come some of these collections are sets and some are iterables?

https://codereview.chromium.org/2318593003/diff/1/pkg/compiler/lib/src/univer...
pkg/compiler/lib/src/universe/universe.dart:409: abstract class CodegenUniverse
implements Universe {
add dartdoc for this class

https://codereview.chromium.org/2318593003/diff/1/pkg/compiler/lib/src/univer...
pkg/compiler/lib/src/universe/universe.dart:504: void
registerTypeInstantiation(InterfaceType type,
On 2016/09/06 17:57:43, Siggi Cherem (dart-lang) wrote:
> should some of this shared code be in a shared super class?
> 
> 
> But let's not call it _BigBang....
> 
>   class CodegenUniverseImpl extends _BigBang { ... }
> 
> ;-)
> 
> 
> 
> 

I would suggest 'UniverseBase'

[Johnni Winther, 2016-09-21 09:13:04]

https://codereview.chromium.org/2318593003/diff/1/pkg/compiler/lib/src/compil...
File pkg/compiler/lib/src/compiler.dart (right):

https://codereview.chromium.org/2318593003/diff/1/pkg/compiler/lib/src/compil...
pkg/compiler/lib/src/compiler.dart:330: ResolutionUniverse get resolverWorld =>
enqueuer.resolution.universe;
On 2016/09/19 18:07:10, Harry Terkelsen wrote:
> also change the names to resolverUniverse and codegenUniverse?

I'll wait with that until the unification of worlds/universes has been done.
Added a TODO.

https://codereview.chromium.org/2318593003/diff/1/pkg/compiler/lib/src/js_bac...
File pkg/compiler/lib/src/js_backend/enqueuer.dart (left):

https://codereview.chromium.org/2318593003/diff/1/pkg/compiler/lib/src/js_bac...
pkg/compiler/lib/src/js_backend/enqueuer.dart:572:
universe.callMethodsWithFreeTypeVariables.add(element);
On 2016/09/19 18:07:10, Harry Terkelsen wrote:
> where is this being registered now?

This and closurizedMembers below are only used in ResolutionUniverse

https://codereview.chromium.org/2318593003/diff/1/pkg/compiler/lib/src/univer...
File pkg/compiler/lib/src/universe/universe.dart (right):

https://codereview.chromium.org/2318593003/diff/1/pkg/compiler/lib/src/univer...
pkg/compiler/lib/src/universe/universe.dart:138: Set<Element> get
closuresWithFreeTypeVariables;
On 2016/09/19 18:07:10, Harry Terkelsen wrote:
> how come some of these collections are sets and some are iterables?

This is added to from the outside. Will be changed later.

https://codereview.chromium.org/2318593003/diff/1/pkg/compiler/lib/src/univer...
pkg/compiler/lib/src/universe/universe.dart:156: // TODO(johnniwinther): Improve
semantic precision.
On 2016/09/06 17:57:43, Siggi Cherem (dart-lang) wrote:
> remove TODO (it's already in the impl class below)

Done.

https://codereview.chromium.org/2318593003/diff/1/pkg/compiler/lib/src/univer...
pkg/compiler/lib/src/universe/universe.dart:409: abstract class CodegenUniverse
implements Universe {
On 2016/09/19 18:07:10, Harry Terkelsen wrote:
> add dartdoc for this class

Done.

https://codereview.chromium.org/2318593003/diff/1/pkg/compiler/lib/src/univer...
pkg/compiler/lib/src/universe/universe.dart:504: void
registerTypeInstantiation(InterfaceType type,
On 2016/09/19 18:07:10, Harry Terkelsen wrote:
> On 2016/09/06 17:57:43, Siggi Cherem (dart-lang) wrote:
> > should some of this shared code be in a shared super class?
> > 
> > 
> > But let's not call it _BigBang....
> > 
> >   class CodegenUniverseImpl extends _BigBang { ... }
> > 
> > ;-)
> > 
> > 
> > 
> > 
> 
> I would suggest 'UniverseBase'

I'll wait with that until the unification of worlds/universes has been done.
Added a TODO.

[Johnni Winther, 2016-09-21 09:24:33]

Description was changed from

==========
Split Universe into ResolutionUniverse and CodegenUniverse

Main changes in universe.dart
==========

to

==========
Split Universe into ResolutionUniverse and CodegenUniverse

Main changes in universe.dart

R=het@google.com, sigmund@google.com

Committed:
https://github.com/dart-lang/sdk/commit/012229ec833a6f1a3922810fa966d6cd611fa99e
==========

[Johnni Winther, 2016-09-21 09:24:35]

Committed patchset #3 (id:40001) manually as
012229ec833a6f1a3922810fa966d6cd611fa99e (presubmit successful).