components/password_manager/core/browser/password_generation_manager.cc - Issue 2318533002: [Password Generation] Use signatures for form matching

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: components/password_manager/core/browser/password_generation_manager.cc

Issue 2318533002: [Password Generation] Use signatures for form matching (Closed)

Patch Set: Sent to review Created 4 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« components/autofill/core/common/signatures_util.cc ('K') | « components/password_manager/core/browser/password_form_manager_unittest.cc ('k') | components/password_manager/core/browser/password_generation_manager_unittest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: components/password_manager/core/browser/password_generation_manager.cc

diff --git a/components/password_manager/core/browser/password_generation_manager.cc b/components/password_manager/core/browser/password_generation_manager.cc

index d1b364127922e52a75cb1f0169154becc7a1fdaa..7e2b733d54a7f61e794ba3ffabecdf52e26b920b 100644

--- a/components/password_manager/core/browser/password_generation_manager.cc

+++ b/components/password_manager/core/browser/password_generation_manager.cc

@@ -41,8 +41,8 @@ void PasswordGenerationManager::DetectFormsEligibleForGeneration(

if (field->server_type() == autofill::ACCOUNT_CREATION_PASSWORD ||

field->server_type() == autofill::NEW_PASSWORD) {

forms_eligible_for_generation.push_back(

- autofill::PasswordFormGenerationData{form->form_name(),

- form->target_url(), *field});

+ autofill::PasswordFormGenerationData{form->form_signature(),

+ field->FieldSignature()});

break;

}