Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(119)

Side by Side Diff: components/password_manager/core/browser/browser_save_password_progress_logger.cc

Issue 2318533002: [Password Generation] Use signatures for form matching (Closed)
Patch Set: Rebase Created 4 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright 2014 The Chromium Authors. All rights reserved. 1 // Copyright 2014 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "components/password_manager/core/browser/browser_save_password_progres s_logger.h" 5 #include "components/password_manager/core/browser/browser_save_password_progres s_logger.h"
6 6
7 #include "base/strings/string_util.h" 7 #include "base/strings/string_util.h"
8 #include "base/strings/utf_string_conversions.h" 8 #include "base/strings/utf_string_conversions.h"
9 #include "base/values.h" 9 #include "base/values.h"
10 #include "components/autofill/core/browser/form_structure.h" 10 #include "components/autofill/core/browser/form_structure.h"
(...skipping 19 matching lines...) Expand all
30 : log_manager_(log_manager) { 30 : log_manager_(log_manager) {
31 DCHECK(log_manager_); 31 DCHECK(log_manager_);
32 } 32 }
33 33
34 void BrowserSavePasswordProgressLogger::LogFormSignatures( 34 void BrowserSavePasswordProgressLogger::LogFormSignatures(
35 SavePasswordProgressLogger::StringID label, 35 SavePasswordProgressLogger::StringID label,
36 const autofill::PasswordForm& form) { 36 const autofill::PasswordForm& form) {
37 autofill::FormStructure form_structure(form.form_data); 37 autofill::FormStructure form_structure(form.form_data);
38 std::string message = GetStringFromID(label) + ": {\n"; 38 std::string message = GetStringFromID(label) + ": {\n";
39 message += GetStringFromID(STRING_FORM_SIGNATURE) + ": " + 39 message += GetStringFromID(STRING_FORM_SIGNATURE) + ": " +
40 ScrubNonDigit(form_structure.FormSignature()) + "\n"; 40 ScrubNonDigit(form_structure.FormSignatureAsStr()) + "\n";
41 message += GetStringFromID(STRING_SIGNON_REALM) + ": " + 41 message += GetStringFromID(STRING_SIGNON_REALM) + ": " +
42 ScrubURL(GURL(form.signon_realm)) + "\n"; 42 ScrubURL(GURL(form.signon_realm)) + "\n";
43 message += 43 message +=
44 GetStringFromID(STRING_ORIGIN) + ": " + ScrubURL(form.origin) + "\n"; 44 GetStringFromID(STRING_ORIGIN) + ": " + ScrubURL(form.origin) + "\n";
45 message += 45 message +=
46 GetStringFromID(STRING_ACTION) + ": " + ScrubURL(form.action) + "\n"; 46 GetStringFromID(STRING_ACTION) + ": " + ScrubURL(form.action) + "\n";
47 message += GetStringFromID(STRING_FORM_NAME) + ": " + 47 message += GetStringFromID(STRING_FORM_NAME) + ": " +
48 ScrubElementID(form.form_data.name) + "\n"; 48 ScrubElementID(form.form_data.name) + "\n";
49 message += GetStringFromID(STRING_FIELDS) + ": " + "\n"; 49 message += GetStringFromID(STRING_FIELDS) + ": " + "\n";
50 50
51 for (const autofill::AutofillField* field : form_structure) { 51 for (const autofill::AutofillField* field : form_structure) {
52 std::string field_info = ScrubElementID(field->name) + ": " + 52 std::string field_info = ScrubElementID(field->name) + ": " +
53 ScrubNonDigit(field->FieldSignature()) + ", " + 53 ScrubNonDigit(field->FieldSignatureAsStr()) +
54 ScrubElementID(field->form_control_type); 54 ", " + ScrubElementID(field->form_control_type);
55 if (!field->autocomplete_attribute.empty()) 55 if (!field->autocomplete_attribute.empty())
56 field_info += ", " + ScrubElementID(field->autocomplete_attribute); 56 field_info += ", " + ScrubElementID(field->autocomplete_attribute);
57 message += field_info + "\n"; 57 message += field_info + "\n";
58 } 58 }
59 message += "}"; 59 message += "}";
60 SendLog(message); 60 SendLog(message);
61 } 61 }
62 62
63 BrowserSavePasswordProgressLogger::~BrowserSavePasswordProgressLogger() {} 63 BrowserSavePasswordProgressLogger::~BrowserSavePasswordProgressLogger() {}
64 64
65 void BrowserSavePasswordProgressLogger::SendLog(const std::string& log) { 65 void BrowserSavePasswordProgressLogger::SendLog(const std::string& log) {
66 log_manager_->LogSavePasswordProgress(log); 66 log_manager_->LogSavePasswordProgress(log);
67 } 67 }
68 68
69 } // namespace password_manager 69 } // namespace password_manager
OLDNEW
« no previous file with comments | « components/autofill/core/common/signatures_util.cc ('k') | components/password_manager/core/browser/password_form_manager.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698