Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(101)

Issue 231853006: SkRecord: turn on cull annotation pass in public API. (Closed)

Created:
6 years, 8 months ago by mtklein_C
Modified:
6 years, 8 months ago
Reviewers:
mtklein, f(malita), reed1
CC:
skia-review_googlegroups.com
Base URL:
https://skia.googlesource.com/skia.git@master
Visibility:
Public.

Description

SkRecord: turn on cull annotation pass in public API. Also, switch Skia internal tools over to use the public headers where possible. Where it's not, the tools -Isrc/record explicitly now, and if it's not obvious, note why they don't use SkRecording.h. BUG=skia:2378 Committed: http://code.google.com/p/skia/source/detail?r=14191

Patch Set 1 #

Patch Set 2 : add back null check #

Patch Set 3 : rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+23 lines, -20 lines) Patch
M dm/DMRecordTask.cpp View 2 chunks +8 lines, -9 lines 0 comments Download
M gyp/record.gyp View 1 chunk +1 line, -2 lines 0 comments Download
M gyp/tests.gypi View 1 chunk +1 line, -0 lines 0 comments Download
M gyp/tools.gyp View 1 chunk +1 line, -2 lines 0 comments Download
M include/record/SkRecording.h View 1 chunk +1 line, -1 line 0 comments Download
M src/record/SkRecording.cpp View 2 chunks +4 lines, -2 lines 0 comments Download
M tools/bench_playback.cpp View 1 chunk +2 lines, -0 lines 0 comments Download
M tools/bench_record.cpp View 1 2 2 chunks +5 lines, -4 lines 0 comments Download

Messages

Total messages: 10 (0 generated)
mtklein
Can't test with Florin's culling if I don't annotate the push/pop pairs... duh...
6 years, 8 months ago (2014-04-13 11:20:10 UTC) #1
reed1
lgtm
6 years, 8 months ago (2014-04-14 19:03:39 UTC) #2
f(malita)
lgtm
6 years, 8 months ago (2014-04-14 19:08:19 UTC) #3
mtklein
lgtm
6 years, 8 months ago (2014-04-14 19:25:02 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://skia-tree-status.appspot.com/cq/mtklein@chromium.org/231853006/20001
6 years, 8 months ago (2014-04-14 19:25:20 UTC) #5
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 8 months ago (2014-04-14 19:33:22 UTC) #6
commit-bot: I haz the power
Retried try job too often on Build-Mac10.8-Clang-x86-Release-Trybot for step(s) BuildBench, BuildEverything, BuildGm, BuildSkiaLib, BuildTests, BuildTools ...
6 years, 8 months ago (2014-04-14 19:33:23 UTC) #7
mtklein
The CQ bit was checked by mtklein@google.com
6 years, 8 months ago (2014-04-14 19:37:42 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://skia-tree-status.appspot.com/cq/mtklein@chromium.org/231853006/40001
6 years, 8 months ago (2014-04-14 19:37:52 UTC) #9
commit-bot: I haz the power
6 years, 8 months ago (2014-04-14 20:33:11 UTC) #10
Message was sent while issue was closed.
Change committed as 14191

Powered by Google App Engine
This is Rietveld 408576698